Change in coreboot[master]: mb/../tglrvp ish: enable ISH driver and register firmware name
Li1 Feng has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39481 )
Change subject: mb/../tglrvp ish: enable ISH driver and register firmware name ......................................................................
mb/../tglrvp ish: enable ISH driver and register firmware name
BRANCH=none BUG=b:145946347 TEST=none
Signed-off-by: Hu, Hebo hebo.hu@intel.com Signed-off-by: li feng li1.feng@intel.com Change-Id: I1ee8050aef6ec0828f16ef2695b5347278caa820 --- M src/mainboard/intel/tglrvp/Kconfig M src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb M src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb 3 files changed, 13 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/39481/1
diff --git a/src/mainboard/intel/tglrvp/Kconfig b/src/mainboard/intel/tglrvp/Kconfig index 2051a05..d60918f 100644 --- a/src/mainboard/intel/tglrvp/Kconfig +++ b/src/mainboard/intel/tglrvp/Kconfig @@ -14,6 +14,7 @@ select GENERATE_SMBIOS_TABLES select SOC_INTEL_TIGERLAKE select INTEL_LPSS_UART_FOR_CONSOLE + select DRIVERS_INTEL_ISH
config CHROMEOS bool diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb index 4492acb..85f7875 100644 --- a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb +++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb @@ -133,7 +133,12 @@ device pci 10.2 off end # CNVi: BT 0xA0F5 - A0F7 device pci 10.6 off end # THC0 0xA0D0 device pci 10.7 off end # THC1 0xA0D1 - device pci 12.0 off end # SensorHUB 0xA0FC + device pci 12.0 on # SensorHUB 0xA0FC + chip drivers/intel/ish + register "firmware_name" = ""tglrvp_ish.bin"" + device generic 0 on end + end + end device pci 12.6 off end # GSPI2 0x34FB device pci 13.0 off end # GSPI3 0xA0FD device pci 14.0 on end # USB3.1 xHCI 0xA0ED diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb index 643db36..586fd26 100644 --- a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb +++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb @@ -129,7 +129,12 @@ device pci 10.2 off end # CNVi: BT 0xA0F5 - A0F7 device pci 10.6 off end # THC0 0xA0D0 device pci 10.7 off end # THC1 0xA0D1 - device pci 12.0 off end # SensorHUB 0xA0FC + device pci 12.0 on # SensorHUB 0xA0FC + chip drivers/intel/ish + register "firmware_name" = ""tglrvp_ish.bin"" + device generic 0 on end + end + end device pci 12.6 off end # GSPI2 0x34FB device pci 13.0 off end # GSPI3 0xA0FD device pci 14.0 on end # USB3.1 xHCI 0xA0ED
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39481 )
Change subject: mb/../tglrvp ish: enable ISH driver and register firmware name ......................................................................
Patch Set 1: Code-Review+2
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39481 )
Change subject: mb/../tglrvp ish: enable ISH driver and register firmware name ......................................................................
Patch Set 1: Code-Review+1
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39481 )
Change subject: mb/../tglrvp ish: enable ISH driver and register firmware name ......................................................................
Patch Set 1:
(1 comment)
Add topic info: TGL_UPSTREAM
https://review.coreboot.org/c/coreboot/+/39481/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39481/1//COMMIT_MSG@11 PS1, Line 11: TEST=none Add test information
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39481 )
Change subject: mb/../tglrvp ish: enable ISH driver and register firmware name ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39481/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39481/1//COMMIT_MSG@7 PS1, Line 7: enable Enable
https://review.coreboot.org/c/coreboot/+/39481/1//COMMIT_MSG@7 PS1, Line 7: mb/../tglrvp mb/intel/tglrvp:
Hello build bot (Jenkins), Wonkyu Kim, Raj Astekar,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39481
to look at the new patch set (#2).
Change subject: mb/intel/tglrvp: enable ISH driver and register firmware name ......................................................................
mb/intel/tglrvp: enable ISH driver and register firmware name
BRANCH=none BUG=b:145946347 TEST=none
Signed-off-by: Hu, Hebo hebo.hu@intel.com Signed-off-by: li feng li1.feng@intel.com Change-Id: I1ee8050aef6ec0828f16ef2695b5347278caa820 --- M src/mainboard/intel/tglrvp/Kconfig M src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb M src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb 3 files changed, 13 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/39481/2
Hello build bot (Jenkins), Wonkyu Kim, Raj Astekar,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39481
to look at the new patch set (#3).
Change subject: TGL_UPSTREAM: mb/intel/tglrvp: Enable ISH driver and register firmware name ......................................................................
TGL_UPSTREAM: mb/intel/tglrvp: Enable ISH driver and register firmware name
BRANCH=none BUG=b:145946347 TEST=none
Signed-off-by: Hu, Hebo hebo.hu@intel.com Signed-off-by: li feng li1.feng@intel.com Change-Id: I1ee8050aef6ec0828f16ef2695b5347278caa820 --- M src/mainboard/intel/tglrvp/Kconfig M src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb M src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb 3 files changed, 13 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/39481/3
Hello build bot (Jenkins), Wonkyu Kim, Raj Astekar,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39481
to look at the new patch set (#4).
Change subject: mb/intel/tglrvp: Enable ISH driver and register firmware name ......................................................................
mb/intel/tglrvp: Enable ISH driver and register firmware name
BRANCH=none BUG=b:145946347 TEST=none
Signed-off-by: Hu, Hebo hebo.hu@intel.com Signed-off-by: li feng li1.feng@intel.com Change-Id: I1ee8050aef6ec0828f16ef2695b5347278caa820 --- M src/mainboard/intel/tglrvp/Kconfig M src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb M src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb 3 files changed, 13 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/39481/4
Hello build bot (Jenkins), Wonkyu Kim, Raj Astekar,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39481
to look at the new patch set (#6).
Change subject: mb/intel/tglrvp: Enable ISH driver and register firmware name ......................................................................
mb/intel/tglrvp: Enable ISH driver and register firmware name
BRANCH=none BUG=b:145946347 TEST=boot to OS with TGL RVP UP3, then copied ISH firmware to host file system /lib/firmware/intel/tglrvp_ish.bin check "dmesg |grep ish", it shows: ish-loader: ISH firmware intel/tglrvp_ish.bin loaded cros_ec_ishtp: Chrome EC device registered Those means shim loader in coreboot has loaded ISH firmware, and firmware is running successfully.
Signed-off-by: Hu, Hebo hebo.hu@intel.com Signed-off-by: li feng li1.feng@intel.com Change-Id: I1ee8050aef6ec0828f16ef2695b5347278caa820 --- M src/mainboard/intel/tglrvp/Kconfig M src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb M src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb 3 files changed, 13 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/39481/6
Hello build bot (Jenkins), Wonkyu Kim, Raj Astekar,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39481
to look at the new patch set (#7).
Change subject: mb/intel/tglrvp: Enable ISH driver and register firmware name ......................................................................
mb/intel/tglrvp: Enable ISH driver and register firmware name
BRANCH=none BUG=b:145946347 TEST=boot to OS with TGL RVP UP3, then copied ISH firmware to host file system /lib/firmware/intel/tglrvp_ish.bin check "dmesg |grep ish", it shows: ish-loader: ISH firmware intel/tglrvp_ish.bin loaded cros_ec_ishtp: Chrome EC device registered Those means shim loader in coreboot has loaded ISH firmware, and firmware is running successfully.
Signed-off-by: Hu, Hebo hebo.hu@intel.com Signed-off-by: li feng li1.feng@intel.com Change-Id: I1ee8050aef6ec0828f16ef2695b5347278caa820 --- M src/mainboard/intel/tglrvp/Kconfig M src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb M src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb 3 files changed, 13 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/39481/7
Li1 Feng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39481 )
Change subject: mb/intel/tglrvp: Enable ISH driver and register firmware name ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39481/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39481/1//COMMIT_MSG@7 PS1, Line 7: enable
Enable
Done
https://review.coreboot.org/c/coreboot/+/39481/1//COMMIT_MSG@7 PS1, Line 7: mb/../tglrvp
mb/intel/tglrvp:
Done
https://review.coreboot.org/c/coreboot/+/39481/1//COMMIT_MSG@11 PS1, Line 11: TEST=none
Add test information
Done
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39481 )
Change subject: mb/intel/tglrvp: Enable ISH driver and register firmware name ......................................................................
Patch Set 8: Code-Review+2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39481 )
Change subject: mb/intel/tglrvp: Enable ISH driver and register firmware name ......................................................................
Patch Set 8: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39481 )
Change subject: mb/intel/tglrvp: Enable ISH driver and register firmware name ......................................................................
mb/intel/tglrvp: Enable ISH driver and register firmware name
BRANCH=none BUG=b:145946347 TEST=boot to OS with TGL RVP UP3, then copied ISH firmware to host file system /lib/firmware/intel/tglrvp_ish.bin check "dmesg |grep ish", it shows: ish-loader: ISH firmware intel/tglrvp_ish.bin loaded cros_ec_ishtp: Chrome EC device registered Those means shim loader in coreboot has loaded ISH firmware, and firmware is running successfully.
Signed-off-by: Hu, Hebo hebo.hu@intel.com Signed-off-by: li feng li1.feng@intel.com Change-Id: I1ee8050aef6ec0828f16ef2695b5347278caa820 Reviewed-on: https://review.coreboot.org/c/coreboot/+/39481 Reviewed-by: Wonkyu Kim wonkyu.kim@intel.com Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/intel/tglrvp/Kconfig M src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb M src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb 3 files changed, 13 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Wonkyu Kim: Looks good to me, approved
diff --git a/src/mainboard/intel/tglrvp/Kconfig b/src/mainboard/intel/tglrvp/Kconfig index 2051a05..d60918f 100644 --- a/src/mainboard/intel/tglrvp/Kconfig +++ b/src/mainboard/intel/tglrvp/Kconfig @@ -14,6 +14,7 @@ select GENERATE_SMBIOS_TABLES select SOC_INTEL_TIGERLAKE select INTEL_LPSS_UART_FOR_CONSOLE + select DRIVERS_INTEL_ISH
config CHROMEOS bool diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb index a43011f..41a361c 100644 --- a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb +++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb @@ -133,7 +133,12 @@ device pci 10.2 on end # CNVi: BT 0xA0F5 - A0F7 device pci 10.6 off end # THC0 0xA0D0 device pci 10.7 off end # THC1 0xA0D1 - device pci 12.0 off end # SensorHUB 0xA0FC + device pci 12.0 on # SensorHUB 0xA0FC + chip drivers/intel/ish + register "firmware_name" = ""tglrvp_ish.bin"" + device generic 0 on end + end + end device pci 12.6 off end # GSPI2 0x34FB device pci 13.0 off end # GSPI3 0xA0FD device pci 14.0 on end # USB3.1 xHCI 0xA0ED diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb index 643db36..586fd26 100644 --- a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb +++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb @@ -129,7 +129,12 @@ device pci 10.2 off end # CNVi: BT 0xA0F5 - A0F7 device pci 10.6 off end # THC0 0xA0D0 device pci 10.7 off end # THC1 0xA0D1 - device pci 12.0 off end # SensorHUB 0xA0FC + device pci 12.0 on # SensorHUB 0xA0FC + chip drivers/intel/ish + register "firmware_name" = ""tglrvp_ish.bin"" + device generic 0 on end + end + end device pci 12.6 off end # GSPI2 0x34FB device pci 13.0 off end # GSPI3 0xA0FD device pci 14.0 on end # USB3.1 xHCI 0xA0ED
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39481 )
Change subject: mb/intel/tglrvp: Enable ISH driver and register firmware name ......................................................................
Patch Set 9:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1370 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1369 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1368
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Li1 Feng (Code Review)
-
Patrick Georgi (Code Review)
-
Wonkyu Kim (Code Review)