Change in coreboot[master]: soc/intel: Constify struct device *param to sd_fill_soc_gpio_info
Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40708 )
Change subject: soc/intel: Constify struct device *param to sd_fill_soc_gpio_info ......................................................................
soc/intel: Constify struct device *param to sd_fill_soc_gpio_info
sd_fill_soc_gpio_info() does not need to modify device structure. Hence, this change makes the struct device * parameter to this function as const.
Change-Id: I237ee9640ec64061aa9ed7c65ea21740c40b6ae2 Signed-off-by: Furquan Shaikh furquan@google.com --- M src/soc/intel/apollolake/sd.c M src/soc/intel/cannonlake/sd.c M src/soc/intel/common/block/include/intelblocks/sd.h M src/soc/intel/icelake/sd.c M src/soc/intel/jasperlake/sd.c M src/soc/intel/skylake/sd.c 6 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/40708/1
diff --git a/src/soc/intel/apollolake/sd.c b/src/soc/intel/apollolake/sd.c index 68c9bca..1007eb1 100644 --- a/src/soc/intel/apollolake/sd.c +++ b/src/soc/intel/apollolake/sd.c @@ -4,7 +4,7 @@ #include <intelblocks/sd.h> #include "chip.h"
-int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, struct device *dev) +int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev) { config_t *config = config_of(dev);
diff --git a/src/soc/intel/cannonlake/sd.c b/src/soc/intel/cannonlake/sd.c index 68c9bca..1007eb1 100644 --- a/src/soc/intel/cannonlake/sd.c +++ b/src/soc/intel/cannonlake/sd.c @@ -4,7 +4,7 @@ #include <intelblocks/sd.h> #include "chip.h"
-int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, struct device *dev) +int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev) { config_t *config = config_of(dev);
diff --git a/src/soc/intel/common/block/include/intelblocks/sd.h b/src/soc/intel/common/block/include/intelblocks/sd.h index 39ff533..d0a160d 100644 --- a/src/soc/intel/common/block/include/intelblocks/sd.h +++ b/src/soc/intel/common/block/include/intelblocks/sd.h @@ -10,6 +10,6 @@ * Fill the GPIO Interrupt or I/O information that will be used for the * GPIO Connection Descriptor. */ -int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, struct device *dev); +int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev);
#endif /* SOC_INTEL_COMMON_BLOCK_SD_H */ diff --git a/src/soc/intel/icelake/sd.c b/src/soc/intel/icelake/sd.c index db22494..f3c25e4 100644 --- a/src/soc/intel/icelake/sd.c +++ b/src/soc/intel/icelake/sd.c @@ -4,7 +4,7 @@ #include <intelblocks/sd.h> #include <soc/soc_chip.h>
-int sd_fill_soc_gpio_info(struct acpi_gpio *gpio, struct device *dev) +int sd_fill_soc_gpio_info(struct acpi_gpio *gpio, const struct device *dev) { config_t *config = config_of(dev);
diff --git a/src/soc/intel/jasperlake/sd.c b/src/soc/intel/jasperlake/sd.c index db22494..f3c25e4 100644 --- a/src/soc/intel/jasperlake/sd.c +++ b/src/soc/intel/jasperlake/sd.c @@ -4,7 +4,7 @@ #include <intelblocks/sd.h> #include <soc/soc_chip.h>
-int sd_fill_soc_gpio_info(struct acpi_gpio *gpio, struct device *dev) +int sd_fill_soc_gpio_info(struct acpi_gpio *gpio, const struct device *dev) { config_t *config = config_of(dev);
diff --git a/src/soc/intel/skylake/sd.c b/src/soc/intel/skylake/sd.c index 70fc62f..c98f870 100644 --- a/src/soc/intel/skylake/sd.c +++ b/src/soc/intel/skylake/sd.c @@ -4,7 +4,7 @@ #include <intelblocks/sd.h> #include "chip.h"
-int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, struct device *dev) +int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev) { config_t *config = config_of(dev);
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40708 )
Change subject: soc/intel: Constify struct device *param to sd_fill_soc_gpio_info ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40708/1/src/soc/intel/apollolake/sd... File src/soc/intel/apollolake/sd.c:
https://review.coreboot.org/c/coreboot/+/40708/1/src/soc/intel/apollolake/sd... PS1, Line 7: int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/40708/1/src/soc/intel/cannonlake/sd... File src/soc/intel/cannonlake/sd.c:
https://review.coreboot.org/c/coreboot/+/40708/1/src/soc/intel/cannonlake/sd... PS1, Line 7: int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/40708/1/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/sd.h:
https://review.coreboot.org/c/coreboot/+/40708/1/src/soc/intel/common/block/... PS1, Line 13: int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev); "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/40708/1/src/soc/intel/skylake/sd.c File src/soc/intel/skylake/sd.c:
https://review.coreboot.org/c/coreboot/+/40708/1/src/soc/intel/skylake/sd.c@... PS1, Line 7: int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev) "foo* bar" should be "foo *bar"
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40708 )
Change subject: soc/intel: Constify struct device *param to sd_fill_soc_gpio_info ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40708/2/src/soc/intel/apollolake/sd... File src/soc/intel/apollolake/sd.c:
https://review.coreboot.org/c/coreboot/+/40708/2/src/soc/intel/apollolake/sd... PS2, Line 7: int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/40708/2/src/soc/intel/cannonlake/sd... File src/soc/intel/cannonlake/sd.c:
https://review.coreboot.org/c/coreboot/+/40708/2/src/soc/intel/cannonlake/sd... PS2, Line 7: int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/40708/2/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/sd.h:
https://review.coreboot.org/c/coreboot/+/40708/2/src/soc/intel/common/block/... PS2, Line 13: int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev); "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/40708/2/src/soc/intel/skylake/sd.c File src/soc/intel/skylake/sd.c:
https://review.coreboot.org/c/coreboot/+/40708/2/src/soc/intel/skylake/sd.c@... PS2, Line 7: int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev) "foo* bar" should be "foo *bar"
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40708 )
Change subject: soc/intel: Constify struct device *param to sd_fill_soc_gpio_info ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40708/3/src/soc/intel/apollolake/sd... File src/soc/intel/apollolake/sd.c:
https://review.coreboot.org/c/coreboot/+/40708/3/src/soc/intel/apollolake/sd... PS3, Line 7: int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/40708/3/src/soc/intel/cannonlake/sd... File src/soc/intel/cannonlake/sd.c:
https://review.coreboot.org/c/coreboot/+/40708/3/src/soc/intel/cannonlake/sd... PS3, Line 7: int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/40708/3/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/sd.h:
https://review.coreboot.org/c/coreboot/+/40708/3/src/soc/intel/common/block/... PS3, Line 13: int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev); "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/40708/3/src/soc/intel/skylake/sd.c File src/soc/intel/skylake/sd.c:
https://review.coreboot.org/c/coreboot/+/40708/3/src/soc/intel/skylake/sd.c@... PS3, Line 7: int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev) "foo* bar" should be "foo *bar"
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40708 )
Change subject: soc/intel: Constify struct device *param to sd_fill_soc_gpio_info ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40708/4/src/soc/intel/apollolake/sd... File src/soc/intel/apollolake/sd.c:
https://review.coreboot.org/c/coreboot/+/40708/4/src/soc/intel/apollolake/sd... PS4, Line 7: int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/40708/4/src/soc/intel/cannonlake/sd... File src/soc/intel/cannonlake/sd.c:
https://review.coreboot.org/c/coreboot/+/40708/4/src/soc/intel/cannonlake/sd... PS4, Line 7: int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/40708/4/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/sd.h:
https://review.coreboot.org/c/coreboot/+/40708/4/src/soc/intel/common/block/... PS4, Line 13: int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev); "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/40708/4/src/soc/intel/skylake/sd.c File src/soc/intel/skylake/sd.c:
https://review.coreboot.org/c/coreboot/+/40708/4/src/soc/intel/skylake/sd.c@... PS4, Line 7: int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev) "foo* bar" should be "foo *bar"
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40708 )
Change subject: soc/intel: Constify struct device *param to sd_fill_soc_gpio_info ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40708/5/src/soc/intel/apollolake/sd... File src/soc/intel/apollolake/sd.c:
https://review.coreboot.org/c/coreboot/+/40708/5/src/soc/intel/apollolake/sd... PS5, Line 7: int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/40708/5/src/soc/intel/cannonlake/sd... File src/soc/intel/cannonlake/sd.c:
https://review.coreboot.org/c/coreboot/+/40708/5/src/soc/intel/cannonlake/sd... PS5, Line 7: int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/40708/5/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/sd.h:
https://review.coreboot.org/c/coreboot/+/40708/5/src/soc/intel/common/block/... PS5, Line 13: int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev); "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/40708/5/src/soc/intel/skylake/sd.c File src/soc/intel/skylake/sd.c:
https://review.coreboot.org/c/coreboot/+/40708/5/src/soc/intel/skylake/sd.c@... PS5, Line 7: int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev) "foo* bar" should be "foo *bar"
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40708 )
Change subject: soc/intel: Constify struct device *param to sd_fill_soc_gpio_info ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40708/6/src/soc/intel/apollolake/sd... File src/soc/intel/apollolake/sd.c:
https://review.coreboot.org/c/coreboot/+/40708/6/src/soc/intel/apollolake/sd... PS6, Line 7: int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/40708/6/src/soc/intel/cannonlake/sd... File src/soc/intel/cannonlake/sd.c:
https://review.coreboot.org/c/coreboot/+/40708/6/src/soc/intel/cannonlake/sd... PS6, Line 7: int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/40708/6/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/sd.h:
https://review.coreboot.org/c/coreboot/+/40708/6/src/soc/intel/common/block/... PS6, Line 13: int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev); "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/40708/6/src/soc/intel/skylake/sd.c File src/soc/intel/skylake/sd.c:
https://review.coreboot.org/c/coreboot/+/40708/6/src/soc/intel/skylake/sd.c@... PS6, Line 7: int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev) "foo* bar" should be "foo *bar"
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40708 )
Change subject: soc/intel: Constify struct device *param to sd_fill_soc_gpio_info ......................................................................
Patch Set 6: Code-Review+2
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40708 )
Change subject: soc/intel: Constify struct device *param to sd_fill_soc_gpio_info ......................................................................
Patch Set 7:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40708/7/src/soc/intel/apollolake/sd... File src/soc/intel/apollolake/sd.c:
https://review.coreboot.org/c/coreboot/+/40708/7/src/soc/intel/apollolake/sd... PS7, Line 7: int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/40708/7/src/soc/intel/cannonlake/sd... File src/soc/intel/cannonlake/sd.c:
https://review.coreboot.org/c/coreboot/+/40708/7/src/soc/intel/cannonlake/sd... PS7, Line 7: int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/40708/7/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/sd.h:
https://review.coreboot.org/c/coreboot/+/40708/7/src/soc/intel/common/block/... PS7, Line 13: int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev); "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/40708/7/src/soc/intel/skylake/sd.c File src/soc/intel/skylake/sd.c:
https://review.coreboot.org/c/coreboot/+/40708/7/src/soc/intel/skylake/sd.c@... PS7, Line 7: int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev) "foo* bar" should be "foo *bar"
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40708 )
Change subject: soc/intel: Constify struct device *param to sd_fill_soc_gpio_info ......................................................................
soc/intel: Constify struct device *param to sd_fill_soc_gpio_info
sd_fill_soc_gpio_info() does not need to modify device structure. Hence, this change makes the struct device * parameter to this function as const.
Change-Id: I237ee9640ec64061aa9ed7c65ea21740c40b6ae2 Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40708 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aaron Durbin adurbin@chromium.org --- M src/soc/intel/apollolake/sd.c M src/soc/intel/cannonlake/sd.c M src/soc/intel/common/block/include/intelblocks/sd.h M src/soc/intel/icelake/sd.c M src/soc/intel/jasperlake/sd.c M src/soc/intel/skylake/sd.c 6 files changed, 6 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved
diff --git a/src/soc/intel/apollolake/sd.c b/src/soc/intel/apollolake/sd.c index 68c9bca..1007eb1 100644 --- a/src/soc/intel/apollolake/sd.c +++ b/src/soc/intel/apollolake/sd.c @@ -4,7 +4,7 @@ #include <intelblocks/sd.h> #include "chip.h"
-int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, struct device *dev) +int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev) { config_t *config = config_of(dev);
diff --git a/src/soc/intel/cannonlake/sd.c b/src/soc/intel/cannonlake/sd.c index 68c9bca..1007eb1 100644 --- a/src/soc/intel/cannonlake/sd.c +++ b/src/soc/intel/cannonlake/sd.c @@ -4,7 +4,7 @@ #include <intelblocks/sd.h> #include "chip.h"
-int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, struct device *dev) +int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev) { config_t *config = config_of(dev);
diff --git a/src/soc/intel/common/block/include/intelblocks/sd.h b/src/soc/intel/common/block/include/intelblocks/sd.h index 39ff533..d0a160d 100644 --- a/src/soc/intel/common/block/include/intelblocks/sd.h +++ b/src/soc/intel/common/block/include/intelblocks/sd.h @@ -10,6 +10,6 @@ * Fill the GPIO Interrupt or I/O information that will be used for the * GPIO Connection Descriptor. */ -int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, struct device *dev); +int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev);
#endif /* SOC_INTEL_COMMON_BLOCK_SD_H */ diff --git a/src/soc/intel/icelake/sd.c b/src/soc/intel/icelake/sd.c index db22494..f3c25e4 100644 --- a/src/soc/intel/icelake/sd.c +++ b/src/soc/intel/icelake/sd.c @@ -4,7 +4,7 @@ #include <intelblocks/sd.h> #include <soc/soc_chip.h>
-int sd_fill_soc_gpio_info(struct acpi_gpio *gpio, struct device *dev) +int sd_fill_soc_gpio_info(struct acpi_gpio *gpio, const struct device *dev) { config_t *config = config_of(dev);
diff --git a/src/soc/intel/jasperlake/sd.c b/src/soc/intel/jasperlake/sd.c index db22494..f3c25e4 100644 --- a/src/soc/intel/jasperlake/sd.c +++ b/src/soc/intel/jasperlake/sd.c @@ -4,7 +4,7 @@ #include <intelblocks/sd.h> #include <soc/soc_chip.h>
-int sd_fill_soc_gpio_info(struct acpi_gpio *gpio, struct device *dev) +int sd_fill_soc_gpio_info(struct acpi_gpio *gpio, const struct device *dev) { config_t *config = config_of(dev);
diff --git a/src/soc/intel/skylake/sd.c b/src/soc/intel/skylake/sd.c index 70fc62f..c98f870 100644 --- a/src/soc/intel/skylake/sd.c +++ b/src/soc/intel/skylake/sd.c @@ -4,7 +4,7 @@ #include <intelblocks/sd.h> #include "chip.h"
-int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, struct device *dev) +int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, const struct device *dev) { config_t *config = config_of(dev);
-
Aaron Durbin (Code Review) -
build bot (Jenkins) (Code Review)
-
Furquan Shaikh (Code Review)