Attention is currently required from: Felix Held, Julius Werner, Marshall Dawson, Zheng Bao, ritul guru.
Bao Zheng has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/84530?usp=email )
Change subject: amdfwtool: Set address mode as relative table ......................................................................
Patch Set 9:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84530/comment/f7057ad9_0c9da306?usp... : PS8, Line 12: the entry address mode is not set. That is not correct.
maybe i misread the code, but isn't the entry address mode set accordingly if the table address mode […]
Address mode 1, which is relative to BIOS.
https://review.coreboot.org/c/coreboot/+/84530/comment/f1f308c1_23e31f3f?usp... : PS8, Line 12: the entry address mode is not set. That is not correct.
maybe i misread the code, but isn't the entry address mode set accordingly if the table address mode […]
This attribute is ignored if the directory address mode is 1 (not 2 or 3). But we can use this "ignored" bit field. We can transfer the information for table header to entries. It doesn't affect any old and later family.