Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29162 )
Change subject: soc/intel/icelake: Do initial SoC commit ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/29162/8/src/soc/intel/icelake/inclu... File src/soc/intel/icelake/include/soc/gpio_defs.h:
https://review.coreboot.org/c/coreboot/+/29162/8/src/soc/intel/icelake/inclu... PS8, Line 249: #define GPI_SMI_STS_0 0x180 : #define GPI_SMI_EN_0 0x1A0 : well, that is, what happens when always cloning from older socs instead of doing it right... these are wrong. according to 341081-002 they should be STS=0x170, EN=0x190