Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Felix Held.
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63645 )
Change subject: mb/google/brya/variants/baseboard/brask: fix boot beep
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63645/comment/33f6d8f4_af29de2a
PS1, Line 8:
Please start by describing the problem. […]
Thanks for review.
https://review.coreboot.org/c/coreboot/+/63645/comment/d157b979_456e1632
PS1, Line 9: GPP_B14 is used for PWM_PP3300_BUZZER.
: The gpio lock causes boot beep fail.
: Modify GPP_B4 from PAD_CFG_NF_LOCK to PAD_CFG_NF.
Please reflow for 72 characters per line.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63645
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I601735ab20974cd992ca5dd6dbaca1517a395aa2
Gerrit-Change-Number: 63645
Gerrit-PatchSet: 2
Gerrit-Owner: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 15 Apr 2022 07:27:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment