Attention is currently required from: Jason Glenesk, ritul guru, Paul Menzel, Anand Vaikar, Felix Held.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74191 )
Change subject: mb/amd/mayan: Update DXIO descriptors per schematics ......................................................................
Patch Set 3:
(5 comments)
File src/mainboard/amd/mayan/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/74191/comment/e1fb9c0b_bc59700c PS3, Line 42: .link_aspm = 2, Prefer using the enums in vc/amd/fsp/phoenix/platform_descriptors.h - `ASPM_L1` here
This also applies to the other entries
https://review.coreboot.org/c/coreboot/+/74191/comment/13661fe5_def3ee2c PS3, Line 43: .link_aspm_L1_1 = 1, : .link_aspm_L1_2 = 1, Prefer using `true` here over `1`
https://review.coreboot.org/c/coreboot/+/74191/comment/d8be3362_40c511e5 PS3, Line 47: .clk_pm_support = 1, Does the FSP support this?
https://review.coreboot.org/c/coreboot/+/74191/comment/90fc1683_d54bd3d8 PS3, Line 66: //.gpio_group_id = 30, Is this just a placeholder for now? If so, please add "TODO". If not, please remove
https://review.coreboot.org/c/coreboot/+/74191/comment/97998a2c_70b65ddf PS3, Line 90: }, GBE? SD card? WLAN?
-
Fred Reitberger (Code Review)