Attention is currently required from: Raul Rangel, Karthik Ramasubramanian, Felix Held. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62903 )
Change subject: mb/google/skyrim: Add DXIO descriptors ......................................................................
Patch Set 10:
(3 comments)
File src/mainboard/google/skyrim/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/62903/comment/bb3f39a7_11f7be83 PS8, Line 38: .start_logical_lane = 2, : .end_logical_lane = 3,
Ack
I was able to boot to the OS with this patch, so I think it's correct? Is there anything else to check?
https://review.coreboot.org/c/coreboot/+/62903/comment/6dbec63f_f4bef4ff PS8, Line 102: { /* DDI2 - DP (type C) */
Ack
I'm not sure how to test this in our current configuration, but this CL is blocking our ability to boot, can we submit this patch and revisit DDI later?
File src/mainboard/google/skyrim/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/62903/comment/7479e4d9_9ce16cdf PS10, Line 20: .gpio_group_id = GPIO_7,
Remove the AUX Reset GPIO for now since FSP is not happy restoring more than 2 GPIOs.
Done
-
Jon Murphy (Code Review)