build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29563 )
Change subject: security/tpm: Fix TCPA log feature ......................................................................
Patch Set 40:
(10 comments)
https://review.coreboot.org/#/c/29563/40/src/include/memlayout.h File src/include/memlayout.h:
https://review.coreboot.org/#/c/29563/40/src/include/memlayout.h@167 PS40, Line 167: #define VBOOT2_TPM_LOG(addr, size) \ Macros with multiple statements should be enclosed in a do - while loop
https://review.coreboot.org/#/c/29563/40/src/include/memlayout.h@167 PS40, Line 167: #define VBOOT2_TPM_LOG(addr, size) \ macros should not use a trailing semicolon
https://review.coreboot.org/#/c/29563/40/src/security/tpm/tspi.h File src/security/tpm/tspi.h:
https://review.coreboot.org/#/c/29563/40/src/security/tpm/tspi.h@50 PS40, Line 50: uint32_t tpm_extend_pcr(int pcr, const char *digest_type, uint8_t *digest, size_t digest_len, line over 80 characters
https://review.coreboot.org/#/c/29563/40/src/security/tpm/tspi/log.c File src/security/tpm/tspi/log.c:
https://review.coreboot.org/#/c/29563/40/src/security/tpm/tspi/log.c@37 PS40, Line 37: size_t tcpa_log_len = sizeof(struct tcpa_table) + MAX_TCPA_LOG_ENTRIES * sizeof(struct tcpa_entry); line over 80 characters
https://review.coreboot.org/#/c/29563/40/src/security/tpm/tspi/log.c@44 PS40, Line 44: strncpy((char *)tclt->header, TCPA_LOG_HEADER, sizeof(tclt->header)); line over 80 characters
https://review.coreboot.org/#/c/29563/40/src/security/tpm/tspi/log.c@50 PS40, Line 50: if (!cbmem_possibly_online() && IS_ENABLED(CONFIG_VBOOT_TCPA_LOG_RECOVERY)) { line over 80 characters
https://review.coreboot.org/#/c/29563/40/src/security/tpm/tspi/log.c@53 PS40, Line 53: if (strncmp(TCPA_LOG_HEADER, (const char *)tclt->header, sizeof(tclt->header))) { line over 80 characters
https://review.coreboot.org/#/c/29563/40/src/security/tpm/tspi/log.c@56 PS40, Line 56: strncpy((char *)tclt->header, TCPA_LOG_HEADER, sizeof(tclt->header)); line over 80 characters
https://review.coreboot.org/#/c/29563/40/src/security/tpm/tspi/log.c@91 PS40, Line 91: void tcpa_log_add_table_entry(const char *name, const uint32_t pcr, const char *digest_type, line over 80 characters
https://review.coreboot.org/#/c/29563/40/src/security/vboot/secdata_tpm.c File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/#/c/29563/40/src/security/vboot/secdata_tpm.c@86 PS40, Line 86: return tpm_extend_pcr(pcr, "SHA256", buffer, size, TPM_PCR_GBB_HWID_NAME); line over 80 characters
-
build bot (Jenkins) (Code Review)