Peichao Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36716 )
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
mb/google/hatch/var/akemi: tune DPTF for Akemi
Need tune DPTF insure it meets Lenovo DPTF Spec
BUG=b:144195069 TEST=FW_NAME="akemi" emerge-hatch coreboot chromeos-ec chromeos-bootimage
Change-Id: Ie0e6d93e1fc0c684e067d1450eb119a53cfefaed --- M src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/36716/1
diff --git a/src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl b/src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl index bb46fe9..3b5f2aa 100644 --- a/src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl +++ b/src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl @@ -44,7 +44,7 @@ #define DPTF_TSR2_SENSOR_ID 2 #define DPTF_TSR2_SENSOR_NAME "Thermal Sensor - CPU" #define DPTF_TSR2_PASSIVE 60 -#define DPTF_TSR2_CRITICAL 75 +#define DPTF_TSR2_CRITICAL 105 #define DPTF_TSR2_ACTIVE_AC0 51 #define DPTF_TSR2_ACTIVE_AC1 48 #define DPTF_TSR2_ACTIVE_AC2 45 @@ -129,7 +129,7 @@ Package () { /* Power Limit 1 */ 0, /* PowerLimitIndex, 0 for Power Limit 1 */ 3000, /* PowerLimitMinimum */ - 15000, /* PowerLimitMaximum */ + 12000, /* PowerLimitMaximum */ 28000, /* TimeWindowMinimum */ 32000, /* TimeWindowMaximum */ 200 /* StepSize */
Hello Paul Fagerburg, Philip Chen, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36716
to look at the new patch set (#2).
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
mb/google/hatch/var/akemi: tune DPTF for Akemi
Need tune DPTF insure it meets Akemi DPTF Spec
BUG=b:144195069 TEST=FW_NAME="akemi" emerge-hatch coreboot chromeos-ec chromeos-bootimage
Change-Id: Ie0e6d93e1fc0c684e067d1450eb119a53cfefaed --- M src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/36716/2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36716 )
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36716/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/36716/2/src/mainboard/google/hatch/... PS2, Line 132: 12000 Doesn't this need to be updated too: https://review.coreboot.org/cgit/coreboot.git/tree/src/mainboard/google/hatc...
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36716 )
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36716/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/36716/2/src/mainboard/google/hatch/... PS2, Line 47: DPTF_TSR2_CRITICAL Upgrade Thermal sensor critical temp from 75 to 105
https://review.coreboot.org/c/coreboot/+/36716/2/src/mainboard/google/hatch/... PS2, Line 132: 12000 Limit CPU power from 15Walt to 12Walt. This point need our thermal guy double confirm on our Akmei EVT DUT. Uprev this CL for tracking DPTF tuning.
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36716 )
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
Patch Set 3:
Patch Set 2:
(1 comment)
Done
Hello Paul Fagerburg, Philip Chen, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36716
to look at the new patch set (#4).
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
mb/google/hatch/var/akemi: tune DPTF for Akemi
Need tune DPTF insure it meets Akemi DPTF Spec
BUG=b:144195069 TEST=FW_NAME="akemi" emerge-hatch coreboot chromeos-ec chromeos-bootimage
Signed-off-by: Peichao.Wang peichao.wang@bitland.corp-partner.google.com Change-Id: Ie0e6d93e1fc0c684e067d1450eb119a53cfefaed --- M src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/36716/4
Hello Paul Fagerburg, Philip Chen, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36716
to look at the new patch set (#5).
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
mb/google/hatch/var/akemi: tune DPTF for Akemi
Need tune DPTF insure it meets Akemi DPTF Spec
BUG=b:144195069 TEST=FW_NAME="akemi" emerge-hatch coreboot chromeos-ec chromeos-bootimage
Signed-off-by: Peichao.Wang peichao.wang@bitland.corp-partner.google.com Change-Id: Ie0e6d93e1fc0c684e067d1450eb119a53cfefaed --- M src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/36716/5
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36716 )
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
Patch Set 5: Code-Review+1
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36716 )
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36716/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/36716/2/src/mainboard/google/hatch/... PS2, Line 132: 12000
Limit CPU power from 15Walt to 12Walt. […]
The point is that the TDP should be somewhere between the min and max PL1 values, right now you have TDP at 15W, but PL1 can range from 3W to (now) 12W, which doesn't make sense.
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36716 )
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
Patch Set 5:
(1 comment)
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36716/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/36716/2/src/mainboard/google/hatch/... PS2, Line 132: 12000
The point is that the TDP should be somewhere between the min and max PL1 values, right now you have […]
this modification confirm with our thermal guy, our Akemi EVT DUT encounter a problem that will shut down automatically when run fish bowel stress test in our production line, so limit its PL1 to make DUT pass this test.
Hello Paul Fagerburg, Ben Kao, Philip Chen, Tim Wawrzynczak, Marx Wang, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36716
to look at the new patch set (#6).
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
mb/google/hatch/var/akemi: tune DPTF for Akemi
Need tune DPTF insure it meets Akemi DPTF Spec
BUG=b:144195069 TEST=FW_NAME="akemi" emerge-hatch coreboot chromeos-ec chromeos-bootimage
Signed-off-by: Peichao.Wang peichao.wang@bitland.corp-partner.google.com Change-Id: Ie0e6d93e1fc0c684e067d1450eb119a53cfefaed --- M src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl 1 file changed, 17 insertions(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/36716/6
Peichao Li has removed Furquan Shaikh from this change. ( https://review.coreboot.org/c/coreboot/+/36716 )
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
Removed reviewer Furquan Shaikh.
Peichao Li has removed Ben Kao from this change. ( https://review.coreboot.org/c/coreboot/+/36716 )
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
Removed reviewer Ben Kao.
Peichao Li has removed Paul Fagerburg from this change. ( https://review.coreboot.org/c/coreboot/+/36716 )
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
Removed reviewer Paul Fagerburg.
Peichao Li has removed Shelley Chen from this change. ( https://review.coreboot.org/c/coreboot/+/36716 )
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
Removed reviewer Shelley Chen.
Peichao Li has removed Tim Wawrzynczak from this change. ( https://review.coreboot.org/c/coreboot/+/36716 )
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
Removed reviewer Tim Wawrzynczak.
Peichao Li has removed Marx Wang from this change. ( https://review.coreboot.org/c/coreboot/+/36716 )
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
Removed reviewer Marx Wang.
Peichao Li has removed Philip Chen from this change. ( https://review.coreboot.org/c/coreboot/+/36716 )
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
Removed reviewer Philip Chen.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36716
to look at the new patch set (#8).
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
mb/google/hatch/var/akemi: tune DPTF for Akemi
Need tune DPTF insure it meets Akemi DPTF Spec
BUG=b:144195069 TEST=FW_NAME="akemi" emerge-hatch coreboot chromeos-ec chromeos-bootimage
Signed-off-by: Peichao.Wang peichao.wang@bitland.corp-partner.google.com Change-Id: Ie0e6d93e1fc0c684e067d1450eb119a53cfefaed --- M src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl 1 file changed, 32 insertions(+), 25 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/36716/8
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36716
to look at the new patch set (#9).
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
mb/google/hatch/var/akemi: tune DPTF for Akemi
Need tune DPTF insure it meets Akemi DPTF Spec
BUG=b:144195069 TEST=FW_NAME="akemi" emerge-hatch coreboot chromeos-ec chromeos-bootimage
Signed-off-by: Peichao.Wang peichao.wang@bitland.corp-partner.google.com Change-Id: Ie0e6d93e1fc0c684e067d1450eb119a53cfefaed --- M src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl 1 file changed, 33 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/36716/9
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36716 )
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36716/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/36716/2/src/mainboard/google/hatch/... PS2, Line 132: 12000
Doesn't this need to be updated too: https://review.coreboot.org/cgit/coreboot. […]
Done
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36716 )
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36716/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/36716/2/src/mainboard/google/hatch/... PS2, Line 47: DPTF_TSR2_CRITICAL
Upgrade Thermal sensor critical temp from 75 to 105
Done
https://review.coreboot.org/c/coreboot/+/36716/2/src/mainboard/google/hatch/... PS2, Line 132: 12000
this modification confirm with our thermal guy, our Akemi EVT DUT encounter a problem that will shut […]
Done
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36716 )
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
Patch Set 9:
(4 comments)
https://review.coreboot.org/c/coreboot/+/36716/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36716/9//COMMIT_MSG@9 PS9, Line 9: Need tune DPTF insure it meets Akemi DPTF Spec Tune DPTF to ensure compliance with Akemi DPTF specification.
https://review.coreboot.org/c/coreboot/+/36716/9//COMMIT_MSG@9 PS9, Line 9: Spec spec
https://review.coreboot.org/c/coreboot/+/36716/9//COMMIT_MSG@9 PS9, Line 9: insure ensure?
https://review.coreboot.org/c/coreboot/+/36716/9//COMMIT_MSG@10 PS9, Line 10: Who gave yo uthe spec?
Hello Philip Chen, Marx Wang, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36716
to look at the new patch set (#10).
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
mb/google/hatch/var/akemi: tune DPTF for Akemi
Tune DPTF to ensure compliance with Akemi thermal design requirements
BUG=b:144195069 TEST=FW_NAME="akemi" emerge-hatch coreboot chromeos-ec chromeos-bootimage
Signed-off-by: Peichao.Wang peichao.wang@bitland.corp-partner.google.com Change-Id: Ie0e6d93e1fc0c684e067d1450eb119a53cfefaed --- M src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl 1 file changed, 33 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/36716/10
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36716 )
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36716/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36716/9//COMMIT_MSG@10 PS9, Line 10:
Who gave yo uthe spec?
Dear Paul, sorry I am wrong, it's the thermal design requirements for Akemi.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36716 )
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36716/10/src/mainboard/google/hatch... File src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/36716/10/src/mainboard/google/hatch... PS10, Line 139: 12000, I'm still curious about this value. I thought the TDP was supposed to be contained within the PL1 range (i.e., PL1 is typically set the same as TDP). But Akemi still has the TDP_PL1_override set to 15 Watts (overridetree.cb:2), so I'm just confused as to what this means, with the two values seemingly conflicting.
Hello Philip Chen, Marx Wang, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36716
to look at the new patch set (#11).
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
mb/google/hatch/var/akemi: tune DPTF for Akemi
Tune DPTF to ensure compliance with Akemi thermal design requirements
BUG=b:144195069 TEST=FW_NAME="akemi" emerge-hatch coreboot chromeos-ec chromeos-bootimage
Signed-off-by: Peichao.Wang peichao.wang@bitland.corp-partner.google.com Change-Id: Ie0e6d93e1fc0c684e067d1450eb119a53cfefaed --- M src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl 1 file changed, 42 insertions(+), 37 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/36716/11
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36716 )
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
Patch Set 11: Code-Review+2
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36716 )
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
Patch Set 11:
(6 comments)
https://review.coreboot.org/c/coreboot/+/36716/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36716/9//COMMIT_MSG@9 PS9, Line 9: Need tune DPTF insure it meets Akemi DPTF Spec
Tune DPTF to ensure compliance with Akemi DPTF specification.
Done
https://review.coreboot.org/c/coreboot/+/36716/9//COMMIT_MSG@9 PS9, Line 9: Spec
spec
Done
https://review.coreboot.org/c/coreboot/+/36716/9//COMMIT_MSG@9 PS9, Line 9: insure
ensure?
Done
https://review.coreboot.org/c/coreboot/+/36716/9//COMMIT_MSG@10 PS9, Line 10:
Dear Paul, sorry I am wrong, it's the thermal design requirements for Akemi.
Done
https://review.coreboot.org/c/coreboot/+/36716/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/36716/2/src/mainboard/google/hatch/... PS2, Line 47: DPTF_TSR2_CRITICAL
Done
Done
https://review.coreboot.org/c/coreboot/+/36716/10/src/mainboard/google/hatch... File src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/36716/10/src/mainboard/google/hatch... PS10, Line 139: 12000,
I'm still curious about this value. […]
Done
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36716 )
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36716/11/src/mainboard/google/hatch... File src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/36716/11/src/mainboard/google/hatch... PS11, Line 75: 85, 0xFFFFFFFF, 5500, 180, 1800}, : Package () {79, 0xFFFFFFFF, 5400, 170, 1700}, : Package () {73, 0xFFFFFFFF, 5200, 160, 1600}, : Package () {68, 0xFFFFFFFF, 5000, 150, 1500}, : Package () {62, 0xFFFFFFFF, 4800, 140, 1400}, : Package () {58, 0xFFFFFFFF, 4600, 130, 1300}, : Package () {53, 0xFFFFFFFF, 4400, 110, 1100}, : Package () {49, 0xFFFFFFFF, 4200, 95, 950}, : Package () {46, 0xFFFFFFFF, 4000, 70, 700}, : Package () {42, 0xFFFFFFFF, 3700, 50, 500}, : Package () {40, 0xFFFFFFFF, 3600, 35, 350}, : Package () {36, 0xFFFFFFFF, 3400, 25, 250}, : Package () {33, 0xFFFFFFFF, 3200, 15, 150}, : Package () {3 How did you arrive to these fine tune values ? Also, how did you cross verify that these all values are working ? Please, share these details. Thanks.
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36716 )
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
Patch Set 11:
(1 comment)
Patch Set 11:
(1 comment)
Dear Sumeet, I have loop you in the ticket: 144370669. Besides, our thermal guy will share more test details with you. Many thanks.
https://review.coreboot.org/c/coreboot/+/36716/11/src/mainboard/google/hatch... File src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/36716/11/src/mainboard/google/hatch... PS11, Line 75: 85, 0xFFFFFFFF, 5500, 180, 1800}, : Package () {79, 0xFFFFFFFF, 5400, 170, 1700}, : Package () {73, 0xFFFFFFFF, 5200, 160, 1600}, : Package () {68, 0xFFFFFFFF, 5000, 150, 1500}, : Package () {62, 0xFFFFFFFF, 4800, 140, 1400}, : Package () {58, 0xFFFFFFFF, 4600, 130, 1300}, : Package () {53, 0xFFFFFFFF, 4400, 110, 1100}, : Package () {49, 0xFFFFFFFF, 4200, 95, 950}, : Package () {46, 0xFFFFFFFF, 4000, 70, 700}, : Package () {42, 0xFFFFFFFF, 3700, 50, 500}, : Package () {40, 0xFFFFFFFF, 3600, 35, 350}, : Package () {36, 0xFFFFFFFF, 3400, 25, 250}, : Package () {33, 0xFFFFFFFF, 3200, 15, 150}, : Package () {3
How did you arrive to these fine tune values ? Also, how did you cross verify that these all values […]
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36716 )
Change subject: mb/google/hatch/var/akemi: tune DPTF for Akemi ......................................................................
mb/google/hatch/var/akemi: tune DPTF for Akemi
Tune DPTF to ensure compliance with Akemi thermal design requirements
BUG=b:144195069 TEST=FW_NAME="akemi" emerge-hatch coreboot chromeos-ec chromeos-bootimage
Signed-off-by: Peichao.Wang peichao.wang@bitland.corp-partner.google.com Change-Id: Ie0e6d93e1fc0c684e067d1450eb119a53cfefaed Reviewed-on: https://review.coreboot.org/c/coreboot/+/36716 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl 1 file changed, 42 insertions(+), 37 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl b/src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl index bb46fe9..5c53022 100644 --- a/src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl +++ b/src/mainboard/google/hatch/variants/akemi/include/variant/acpi/dptf.asl @@ -25,33 +25,33 @@ #define DPTF_TSR0_SENSOR_NAME "Thermal Sensor 1" #define DPTF_TSR0_PASSIVE 65 #define DPTF_TSR0_CRITICAL 75 -#define DPTF_TSR0_ACTIVE_AC0 50 -#define DPTF_TSR0_ACTIVE_AC1 47 -#define DPTF_TSR0_ACTIVE_AC2 45 -#define DPTF_TSR0_ACTIVE_AC3 42 -#define DPTF_TSR0_ACTIVE_AC4 39 +#define DPTF_TSR0_ACTIVE_AC0 61 +#define DPTF_TSR0_ACTIVE_AC1 59 +#define DPTF_TSR0_ACTIVE_AC2 57 +#define DPTF_TSR0_ACTIVE_AC3 55 +#define DPTF_TSR0_ACTIVE_AC4 51 +#define DPTF_TSR0_ACTIVE_AC5 48 +#define DPTF_TSR0_ACTIVE_AC6 40
#define DPTF_TSR1_SENSOR_ID 1 #define DPTF_TSR1_SENSOR_NAME "Thermal Sensor 2" -#define DPTF_TSR1_PASSIVE 65 +#define DPTF_TSR1_PASSIVE 38 #define DPTF_TSR1_CRITICAL 75 -#define DPTF_TSR1_ACTIVE_AC0 50 -#define DPTF_TSR1_ACTIVE_AC1 47 -#define DPTF_TSR1_ACTIVE_AC2 45 -#define DPTF_TSR1_ACTIVE_AC3 42 -#define DPTF_TSR1_ACTIVE_AC4 39 +#define DPTF_TSR1_ACTIVE_AC0 42 +#define DPTF_TSR1_ACTIVE_AC1 40 +#define DPTF_TSR1_ACTIVE_AC2 38
#define DPTF_TSR2_SENSOR_ID 2 #define DPTF_TSR2_SENSOR_NAME "Thermal Sensor - CPU" -#define DPTF_TSR2_PASSIVE 60 -#define DPTF_TSR2_CRITICAL 75 -#define DPTF_TSR2_ACTIVE_AC0 51 -#define DPTF_TSR2_ACTIVE_AC1 48 -#define DPTF_TSR2_ACTIVE_AC2 45 -#define DPTF_TSR2_ACTIVE_AC3 42 -#define DPTF_TSR2_ACTIVE_AC4 39 -#define DPTF_TSR2_ACTIVE_AC5 36 -#define DPTF_TSR2_ACTIVE_AC6 33 +#define DPTF_TSR2_PASSIVE 62 +#define DPTF_TSR2_CRITICAL 105 +#define DPTF_TSR2_ACTIVE_AC0 62 +#define DPTF_TSR2_ACTIVE_AC1 61 +#define DPTF_TSR2_ACTIVE_AC2 60 +#define DPTF_TSR2_ACTIVE_AC3 54 +#define DPTF_TSR2_ACTIVE_AC4 51 +#define DPTF_TSR2_ACTIVE_AC5 48 +#define DPTF_TSR2_ACTIVE_AC6 45
#define DPTF_ENABLE_CHARGER #define DPTF_ENABLE_FAN_CONTROL @@ -72,16 +72,21 @@ * These are initial reference values. */ /* Control, Trip Point, Speed, NoiseLevel, Power */ - Package () {90, 0xFFFFFFFF, 6700, 220, 2200}, - Package () {80, 0xFFFFFFFF, 5800, 180, 1800}, - Package () {70, 0xFFFFFFFF, 5000, 145, 1450}, - Package () {60, 0xFFFFFFFF, 4900, 115, 1150}, - Package () {50, 0xFFFFFFFF, 3838, 90, 900}, - Package () {40, 0xFFFFFFFF, 2904, 55, 550}, - Package () {30, 0xFFFFFFFF, 2337, 30, 300}, - Package () {20, 0xFFFFFFFF, 1608, 15, 150}, - Package () {10, 0xFFFFFFFF, 800, 10, 100}, - Package () {0, 0xFFFFFFFF, 0, 0, 50} + Package () {85, 0xFFFFFFFF, 5500, 180, 1800}, + Package () {79, 0xFFFFFFFF, 5400, 170, 1700}, + Package () {73, 0xFFFFFFFF, 5200, 160, 1600}, + Package () {68, 0xFFFFFFFF, 5000, 150, 1500}, + Package () {62, 0xFFFFFFFF, 4800, 140, 1400}, + Package () {58, 0xFFFFFFFF, 4600, 130, 1300}, + Package () {53, 0xFFFFFFFF, 4400, 110, 1100}, + Package () {49, 0xFFFFFFFF, 4200, 95, 950}, + Package () {46, 0xFFFFFFFF, 4000, 70, 700}, + Package () {42, 0xFFFFFFFF, 3700, 50, 500}, + Package () {40, 0xFFFFFFFF, 3600, 35, 350}, + Package () {36, 0xFFFFFFFF, 3400, 25, 250}, + Package () {33, 0xFFFFFFFF, 3200, 15, 150}, + Package () {30, 0xFFFFFFFF, 3000, 5, 50}, + Package () {0, 0xFFFFFFFF, 0, 0, 0} })
Name (DART, Package () { @@ -96,15 +101,15 @@ 0, 0, 0 }, Package () { - _SB.DPTF.TFN1, _SB.DPTF.TSR0, 100, 90, 69, 56, 46, 36, 0, 0, + _SB.DPTF.TFN1, _SB.DPTF.TSR0, 100, 85, 73, 62, 49, 33, 25, 14, 0, 0, 0 }, Package () { - _SB.DPTF.TFN1, _SB.DPTF.TSR1, 100, 90, 69, 56, 46, 36, 0, 0, + _SB.DPTF.TFN1, _SB.DPTF.TSR1, 100, 85, 73, 62, 0, 0, 0, 0, 0, 0, 0 }, Package () { - _SB.DPTF.TFN1, _SB.DPTF.TSR2, 100, 90, 80, 70, 60, 50, 40, 30, + _SB.DPTF.TFN1, _SB.DPTF.TSR2, 100, 85, 73, 62, 56, 33, 25, 14, 0, 0, 0 }, }) @@ -114,13 +119,13 @@ Package () { _SB.PCI0.TCPU, _SB.PCI0.TCPU, 100, 50, 0, 0, 0, 0 },
/* CPU Throttle Effect on Ambient (TSR0) */ - Package () { _SB.PCI0.TCPU, _SB.DPTF.TSR0, 100, 60, 0, 0, 0, 0 }, + Package () { _SB.DPTF.TCHG, _SB.DPTF.TSR0, 100, 60, 0, 0, 0, 0 },
/* Charger Throttle Effect on Charger (TSR1) */ - Package () { _SB.DPTF.TCHG, _SB.DPTF.TSR1, 100, 60, 0, 0, 0, 0 }, + Package () { _SB.PCI0.TCPU, _SB.DPTF.TSR1, 100, 60, 0, 0, 0, 0 },
/* CPU Throttle Effect on CPU (TSR2) */ - Package () { _SB.DPTF.TCHG, _SB.DPTF.TSR2, 100, 60, 0, 0, 0, 0 }, + Package () { _SB.PCI0.TCPU, _SB.DPTF.TSR2, 100, 60, 0, 0, 0, 0 }, })
Name (MPPC, Package () @@ -128,7 +133,7 @@ 0x2, /* Revision */ Package () { /* Power Limit 1 */ 0, /* PowerLimitIndex, 0 for Power Limit 1 */ - 3000, /* PowerLimitMinimum */ + 5000, /* PowerLimitMinimum */ 15000, /* PowerLimitMaximum */ 28000, /* TimeWindowMinimum */ 32000, /* TimeWindowMaximum */
-
Furquan Shaikh (Code Review) -
Patrick Georgi (Code Review)
-
Paul Fagerburg (Code Review)
-
Paul Menzel (Code Review)
-
Peichao Li (Code Review)
-
Sumeet R Pawnikar (Code Review)
-
Tim Wawrzynczak (Code Review)