Attention is currently required from: Eric Lai, Angel Pons, Patrick Rudolph, EricR Lai.
John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62723 )
Change subject: soc/intel/common: Configure TCSS access through IOE P2SB
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/tcss/tcss.c:
https://review.coreboot.org/c/coreboot/+/62723/comment/9fbe99e4_7078001d
PS2, Line 389: else if (CONFIG(SOC_INTEL_COMMON_BLOCK_TCSS_REG_ACCESS_SBI)) {
Is just SOC_INTEL_COMMON_BLOCK_IOE_P2SB sufficient enough?
Under the scope of SOC_INTEL_COMMON_BLOCK_REG_ACCESS_SBI, there is consideration for future platforms expansion beyond the Meteor Lake which has the IOE die. i.e,
else if (CONFIG(SOC_INTEL_COMMON_BLOCK_REG_ACCESS_SBI)) {
if (CONFIG(SOC_INTEL_COMMON_BLOCK_IOE_P2SB))
ioe_tcss_configure_aux_bias_pads_sbi(pads); // MTL with IOE
// TBD
else if (CONFIG(SOC_INTEL_COMMON_BLOCK_XYZ_P2SB))
xyz_tcss_configure_aux_bias_pads_sbi(pads); // XYZ platform
}
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62723
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3302aabfb5f540c41da6359f11376b4202c6310b
Gerrit-Change-Number: 62723
Gerrit-PatchSet: 2
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Angel Pons
angel.pons@9elements.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Angel Pons
angel.pons@9elements.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Sun, 13 Mar 2022 18:27:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment