Attention is currently required from: Frank Wu, Paul Menzel, Felix Held.
Amanda Hwang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63709 )
Change subject: mb/google/brya/var/brya0: Swap TPM and touchscreen I2C bus
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/brya0/gpio.c:
https://review.coreboot.org/c/coreboot/+/63709/comment/3860afda_fa5f775a
PS1, Line 132: /*
: * D1 : ISH_GP1 ==> FP_RST_ODL
: * FP_RST_ODL comes out of reset as hi-z and does not have an external pull-down.
: * To ensure proper power sequencing for the FPMCU device, reset signal is driven low
: * early on in bootblock, followed by enabling of power. Reset signal is deasserted
: * later on in ramstage. Since reset signal is asserted in bootblock, it results in
: * FPMCU not working after a S3 resume. This is a known issue.
: */
Please wrap the lines earlier, and also follow the [commenting style](https://doc.coreboot. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63709
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifa6235869f34e0038a8ecad33d59654626cf7815
Gerrit-Change-Number: 63709
Gerrit-PatchSet: 3
Gerrit-Owner: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 20 Apr 2022 02:41:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment