Name of user not set #1002723 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37661 )
Change subject: my broken build of coreboot ......................................................................
my broken build of coreboot
Change-Id: I5586d07b0e5c3c26f4f4d478ec567067476e3c87 --- A src/mainboard/dell/Kconfig A src/mainboard/dell/Kconfig.name A src/mainboard/dell/dell_system_vostro_3360/Kconfig A src/mainboard/dell/dell_system_vostro_3360/Kconfig.name A src/mainboard/dell/dell_system_vostro_3360/Makefile.inc A src/mainboard/dell/dell_system_vostro_3360/acpi/ec.asl A src/mainboard/dell/dell_system_vostro_3360/acpi/platform.asl A src/mainboard/dell/dell_system_vostro_3360/acpi/superio.asl A src/mainboard/dell/dell_system_vostro_3360/acpi_tables.c A src/mainboard/dell/dell_system_vostro_3360/board_info.txt A src/mainboard/dell/dell_system_vostro_3360/devicetree.cb A src/mainboard/dell/dell_system_vostro_3360/dsdt.asl A src/mainboard/dell/dell_system_vostro_3360/gma-mainboard.ads A src/mainboard/dell/dell_system_vostro_3360/gpio.c A src/mainboard/dell/dell_system_vostro_3360/hda_verb.c A src/mainboard/dell/dell_system_vostro_3360/mainboard.c A src/mainboard/dell/dell_system_vostro_3360/romstage.c A util/autoport/logs/acpidump.log A util/autoport/logs/codec_0 A util/autoport/logs/codec_3 A util/autoport/logs/cpuinfo.log A util/autoport/logs/dmidecode.log A util/autoport/logs/ectool.log A util/autoport/logs/input_bustypes.log A util/autoport/logs/inteltool.log A util/autoport/logs/ioports.log A util/autoport/logs/lspci.log A util/autoport/logs/pin_hwC0D0 A util/autoport/logs/pin_hwC0D3 A util/autoport/logs/superiotool.log 30 files changed, 30,191 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/37661/1
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37661 )
Change subject: my broken build of coreboot ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37661/1/util/autoport/logs/acpidump... File util/autoport/logs/acpidump.log:
https://review.coreboot.org/c/coreboot/+/37661/1/util/autoport/logs/acpidump... PS1, Line 1496: 5180: 5F 30 00 70 0D 55 6E 6B 6E 6F 77 00 88 50 41 4B _0.p.Unknow..PAK 'Unknow' may be misspelled - perhaps 'Unknown'?
https://review.coreboot.org/c/coreboot/+/37661/1/util/autoport/logs/acpidump... PS1, Line 1501: 51D0: 0D 55 6E 6B 6E 6F 77 00 88 50 41 4B 30 0A 0B 00 .Unknow..PAK0... 'Unknow' may be misspelled - perhaps 'Unknown'?
https://review.coreboot.org/c/coreboot/+/37661/1/util/autoport/logs/acpidump... PS1, Line 1516: 52C0: 5F 32 00 70 0D 55 6E 6B 6E 6F 77 00 88 50 41 4B _2.p.Unknow..PAK 'Unknow' may be misspelled - perhaps 'Unknown'?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37661 )
Change subject: my broken build of coreboot ......................................................................
Patch Set 1:
Good to see you managed to push it in the end :D
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37661 )
Change subject: my broken build of coreboot ......................................................................
Patch Set 1:
(6 comments)
Looks like autoport hasn't been updated in a while. See inline comments how to fix building.
https://review.coreboot.org/c/coreboot/+/37661/1/src/mainboard/dell/dell_sys... File src/mainboard/dell/dell_system_vostro_3360/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/37661/1/src/mainboard/dell/dell_sys... PS1, Line 1: romstage-y += gpio.c add
bootblock-y += gpio.c
https://review.coreboot.org/c/coreboot/+/37661/1/src/mainboard/dell/dell_sys... File src/mainboard/dell/dell_system_vostro_3360/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/37661/1/src/mainboard/dell/dell_sys... PS1, Line 18: bd82x6x replace `bd82x6x` with `common`
https://review.coreboot.org/c/coreboot/+/37661/1/src/mainboard/dell/dell_sys... PS1, Line 21: bd82x6x replace `bd82x6x` with `common`
https://review.coreboot.org/c/coreboot/+/37661/1/src/mainboard/dell/dell_sys... File src/mainboard/dell/dell_system_vostro_3360/romstage.c:
https://review.coreboot.org/c/coreboot/+/37661/1/src/mainboard/dell/dell_sys... PS1, Line 33: pch_enable_lpc rename to `mainboard_pch_lpc_setup`
https://review.coreboot.org/c/coreboot/+/37661/1/src/mainboard/dell/dell_sys... PS1, Line 39: void mainboard_rcba_config(void) : { : } drop
https://review.coreboot.org/c/coreboot/+/37661/1/src/mainboard/dell/dell_sys... PS1, Line 60: void mainboard_early_init(int s3resume) : { : } : : void mainboard_config_superio(void) : { : } drop
Name of user not set #1002723 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37661 )
Change subject: my broken build of coreboot ......................................................................
Patch Set 1:
Patch Set 1:
(6 comments)
Looks like autoport hasn't been updated in a while. See inline comments how to fix building.
Ok thanks a lot for your fix. I will push your fix, but I'm having a new issue.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37661 )
Change subject: my broken build of coreboot ......................................................................
Patch Set 1:
I recovered what I had written in a now-deleted change. I'll paste it here as well.
Hi, I see that this code is scattered around various changes on Gerrit. I would recommend keeping things simple: only have a single change that is the mainboard port, which corresponds to a single commit on your local tree.
Gerrit uses the Change-Id line on the commit message to identify changes. When pushing commits, Gerrit looks at the Change-Id. If it already exists on an existing change, then the commit is considered to be an update of that change. Otherwise, it is considered a new change.
The idea is to always use the same Change-Id. If you want to modify something of that commit, just use `git commit --amend`. That way, when you push it to Gerrit, it will show as another patchset of the same change.
-
Angel Pons (Code Review) -
build bot (Jenkins) (Code Review)
-
Name of user not set (Code Review)
-
Nico Huber (Code Review)