Change in coreboot[master]: google/trogdor: Add backlight support for Parade ps8640 - coreboot-gerrit

26 Oct 2021


      Attention is currently required from: Douglas Anderson, Philip Chen, Julius Werner, Xuxin Xiong.
Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58624 )
Change subject: google/trogdor: Add backlight support for Parade ps8640
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/trogdor/mainboard.c:
https://review.coreboot.org/c/coreboot/+/58624/comment/79c537d1_38492d06 
PS6, Line 206: 		if (CONFIG(TROGDOR_HAS_BRIDGE_BACKLIGHT))
             : 			ps8640_backlight_enable(BRIDGE_BUS, BRIDGE_PS8640_CHIP);
Can you move the board-specific change to another patch?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/58624
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ief1bf56c89c8215427dcbddfc67e8bcd4c3607d2
Gerrit-Change-Number: 58624
Gerrit-PatchSet: 6
Gerrit-Owner: Xuxin Xiong xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Douglas Anderson dianders@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Philip Chen philipchen@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Philip Chen philipchen@google.com
Gerrit-Attention: Douglas Anderson dianders@chromium.org
Gerrit-Attention: Philip Chen philipchen@chromium.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Xuxin Xiong xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Tue, 26 Oct 2021 15:51:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment