Change in ...coreboot[master]: google/kukui: Use internal CR50_IRQ pull-up

[You-Cheng Syu (Code Review)]

You-Cheng Syu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32116

Change subject: google/kukui: Use internal CR50_IRQ pull-up
......................................................................

google/kukui: Use internal CR50_IRQ pull-up

For Kukui CR50_IRQ pin, we're going to replace external pull-up with
internal pull-up. This change won't break older boards, so we can just
always do that when setting up GPIOs.

BUG=b:124821269
BRANCH=none
TEST=Waveform looks correct.

Change-Id: Ib1a90dce583a6aa0cec8ac8ba96d1362f50c16a8
Signed-off-by: You-Cheng Syu 
---
M src/mainboard/google/kukui/chromeos.c
1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/32116/1

diff --git a/src/mainboard/google/kukui/chromeos.c b/src/mainboard/google/kukui/chromeos.c
index 132f0d3..09c47ee 100644
--- a/src/mainboard/google/kukui/chromeos.c
+++ b/src/mainboard/google/kukui/chromeos.c
@@ -24,6 +24,7 @@
 {
    gpio_input_pullup(EC_IN_RW);
    gpio_input_pullup(EC_IRQ);
+	gpio_input_pullup(CR50_IRQ);
    gpio_output(GPIO_RESET, 0);
 }

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32116 )

Change subject: google/kukui: Use internal CR50_IRQ pull-up
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32116 )

Change subject: google/kukui: Use internal CR50_IRQ pull-up
......................................................................

google/kukui: Use internal CR50_IRQ pull-up

For Kukui CR50_IRQ pin, we're going to replace external pull-up with
internal pull-up. This change won't break older boards, so we can just
always do that when setting up GPIOs.

BUG=b:124821269
BRANCH=none
TEST=Waveform looks correct.

Change-Id: Ib1a90dce583a6aa0cec8ac8ba96d1362f50c16a8
Signed-off-by: You-Cheng Syu 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32116
Tested-by: build bot (Jenkins) 
Reviewed-by: Hung-Te Lin 
---
M src/mainboard/google/kukui/chromeos.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Hung-Te Lin: Looks good to me, approved

diff --git a/src/mainboard/google/kukui/chromeos.c b/src/mainboard/google/kukui/chromeos.c
index 132f0d3..09c47ee 100644
--- a/src/mainboard/google/kukui/chromeos.c
+++ b/src/mainboard/google/kukui/chromeos.c
@@ -24,6 +24,7 @@
 {
    gpio_input_pullup(EC_IN_RW);
    gpio_input_pullup(EC_IRQ);
+	gpio_input_pullup(CR50_IRQ);
    gpio_output(GPIO_RESET, 0);
 }