[S] Change in coreboot[master]: soc/amd/phoenix: Allow the amdfw.rom to be split into two parts - coreboot-gerrit

6 Mar 2023


      Attention is currently required from: Jason Glenesk, Matt DeVillier, Zheng Bao, Fred Reitberger, Karthik Ramasubramanian, Felix Held.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72703 )
Change subject: soc/amd/phoenix: Allow the amdfw.rom to be split into two parts
......................................................................
Patch Set 11:
(1 comment)
File src/soc/amd/phoenix/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/72703/comment/de6f2d86_d5903c79 
PS9, Line 212: OPT_AMDFW_BODY_LOCATION=$(if $(FMAP_AMDFW_BODY_LOCATION), --body-location $(FMAP_AMDFW_BODY_LOCATION))
...
The `$(if $(FMAP_AMDFW_BODY_LOCATION)` is not needed with `$(call add_opt_prefix` […]
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/72703
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia8b318f71632a2c9b97ce67486374dc24d23e63e
Gerrit-Change-Number: 72703
Gerrit-PatchSet: 11
Gerrit-Owner: Bao Zheng fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 06 Mar 2023 14:27:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bao Zheng fishbaozi@gmail.com
Comment-In-Reply-To: Fred Reitberger reitbergerfred@gmail.com
Gerrit-MessageType: comment