Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37426 )
Change subject: soc/intel/tigerlake: Update Kconfig
......................................................................
Patch Set 13:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37426/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37426/2//COMMIT_MSG@16
PS2, Line 16: 4. Update chip files to include tigerlake PCH DEVFNs
Having a list in a commit message, indicates that the commit should be split up into separate commit […]
Done
https://review.coreboot.org/c/coreboot/+/37426/11//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37426/11//COMMIT_MSG@11
PS11, Line 11: I2C
This is not updated.
Ack
https://review.coreboot.org/c/coreboot/+/37426/11//COMMIT_MSG@11
PS11, Line 11: UART
This is not updated.
Ack
https://review.coreboot.org/c/coreboot/+/37426/11//COMMIT_MSG@13
PS11, Line 13: PCH baseclock
Reference?
We'll provide external document if we can find.
We're trying to find out document. PCH base clock which is used for UART is changed from 120MHz to 100MHz.
So, we needed to update M/N setting for 115200 baudrate.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37426
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I04020d55f1063d521b15f8d0dabbd6f1dabf577c
Gerrit-Change-Number: 37426
Gerrit-PatchSet: 13
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Venkata Krishna Nimmagadda
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.corp-partner.google.com
Gerrit-Comment-Date: Tue, 07 Jan 2020 09:47:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment