Attention is currently required from: Haribalaraman Ramasubramanian, Rizwan Qureshi, Tim Wawrzynczak, Daniil Lunev, Meera Ravindranath, Divagar Mohandass.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68251 )
Change subject: soc/intel/alderlake: Add/Remove LTR disqualification for UFS
......................................................................
Patch Set 6:
(2 comments)
File src/soc/intel/alderlake/include/soc/ufs.h:
https://review.coreboot.org/c/coreboot/+/68251/comment/ed7c2399_903b7484
PS6, Line 26: R_PMC_PWRM_LTR_IGN
Is this in the EDS? I can't see it.
https://review.coreboot.org/c/coreboot/+/68251/comment/4f6c37e0_320be99a
PS6, Line 27: PCH_PWRM_BASE_SIZE
This is redefining a macro from iomap.h. Should it be called something else?
And I don't quite understand what it's doing. Why are you only mapping the region up to 0x1E30 - where does the value 0x1E30 come from?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68251
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I88772b0b7dde1fca0130472a38628e72dfd6c26c
Gerrit-Change-Number: 68251
Gerrit-PatchSet: 6
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Daniil Lunev
dlunev@google.com
Gerrit-Reviewer: Divagar Mohandass
divagar.mohandass@intel.com
Gerrit-Reviewer: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Kangheui Won
khwon@chromium.org
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Daniil Lunev
dlunev@google.com
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: Divagar Mohandass
divagar.mohandass@intel.com
Gerrit-Comment-Date: Mon, 24 Oct 2022 23:30:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment