Change in coreboot[master]: mb/google/hatch/variants/helios: Update GPIO table for proto stage - coreboot-gerrit

12 Aug 2019


      Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33826 )
Change subject: mb/google/hatch/variants/helios: Update GPIO table for proto stage
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33826/7/src/mainboard/google/hatch/... 
File src/mainboard/google/hatch/variants/helios/gpio.c:
https://review.coreboot.org/c/coreboot/+/33826/7/src/mainboard/google/hatch/... 
PS7, Line 95: 	PAD_CFG_GPO(GPP_H13, 1, PLTRST),
...
There is no enable pin for the spkr, right? Also, we do not typically add a power resource for it. […]
Ack
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/33826
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I257a90a97e11651cdf5f85ca743e530ef5e61e56
Gerrit-Change-Number: 33826
Gerrit-PatchSet: 7
Gerrit-Owner: Frank Chu frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Frank Chu frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org
Gerrit-Reviewer: Philip Chen philipchen@google.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kane Chen kane_chen@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 12 Aug 2019 17:15:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment