Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43169 )
Change subject: nb/intel/pineview/acpi: Remove unmatched comment start ......................................................................
nb/intel/pineview/acpi: Remove unmatched comment start
This was silently commenting out the line after it.
Change-Id: I2714090b8f99193ace420ad02e2d42b324349c9e Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/pineview/acpi/hostbridge.asl 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/43169/1
diff --git a/src/northbridge/intel/pineview/acpi/hostbridge.asl b/src/northbridge/intel/pineview/acpi/hostbridge.asl index 1c81c8e..92e8ea7 100644 --- a/src/northbridge/intel/pineview/acpi/hostbridge.asl +++ b/src/northbridge/intel/pineview/acpi/hostbridge.asl @@ -32,7 +32,7 @@
Offset (0x68), /* DMIBAR */ DMEN, 1, /* Enable */ - , 11, /* + , 11, DMBR, 20, /* DMIBAR */
/* ... */
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43169 )
Change subject: nb/intel/pineview/acpi: Remove unmatched comment start ......................................................................
Patch Set 1: Code-Review+2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43169 )
Change subject: nb/intel/pineview/acpi: Remove unmatched comment start ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43169 )
Change subject: nb/intel/pineview/acpi: Remove unmatched comment start ......................................................................
nb/intel/pineview/acpi: Remove unmatched comment start
This was silently commenting out the line after it.
Change-Id: I2714090b8f99193ace420ad02e2d42b324349c9e Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43169 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M src/northbridge/intel/pineview/acpi/hostbridge.asl 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved Frans Hendriks: Looks good to me, approved
diff --git a/src/northbridge/intel/pineview/acpi/hostbridge.asl b/src/northbridge/intel/pineview/acpi/hostbridge.asl index dae0b77..5eae0cb 100644 --- a/src/northbridge/intel/pineview/acpi/hostbridge.asl +++ b/src/northbridge/intel/pineview/acpi/hostbridge.asl @@ -32,7 +32,7 @@
Offset (0x68), /* DMIBAR */ DMEN, 1, /* Enable */ - , 11, /* + , 11, DMBR, 20, /* DMIBAR */
/* ... */
-
Angel Pons (Code Review) -
Frans Hendriks (Code Review)
-
HAOUAS Elyes (Code Review)