Maxim Polyakov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42911 )
Change subject: soc/intel/common/gpio_defs: Improve some GPI macros ......................................................................
soc/intel/common/gpio_defs: Improve some GPI macros
The patch updates existing macros for the GPI:
- PAD_CFG_GPI_IOSSTATE_IOSTERM() - PAD_CFG_GPI_IOSSTATE()
to allow the user to set the RX Level/Edge Configuration (trig) and the Host Software Ownership (own) fileds in addition to IO Standby State (iosstate) and IO Standby Termination (iosterm) in the pad configuration using these macros.
Change-Id: I8a70a366e816d31720d341a5d26880dc32ff9b8d Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/soc/intel/common/block/include/intelblocks/gpio_defs.h 1 file changed, 9 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/42911/1
diff --git a/src/soc/intel/common/block/include/intelblocks/gpio_defs.h b/src/soc/intel/common/block/include/intelblocks/gpio_defs.h index e9abd00..c2c8951 100644 --- a/src/soc/intel/common/block/include/intelblocks/gpio_defs.h +++ b/src/soc/intel/common/block/include/intelblocks/gpio_defs.h @@ -266,15 +266,16 @@ PAD_FUNC(GPIO) | PAD_RESET(rst) | PAD_BUF(TX_DISABLE), \ PAD_PULL(pull) | PAD_IOSSTATE(TxDRxE))
-#define PAD_CFG_GPI_IOSSTATE(pad, pull, rst, iosstate) \ - _PAD_CFG_STRUCT(pad, \ - PAD_FUNC(GPIO) | PAD_RESET(rst) | PAD_CFG0_TX_DISABLE, \ - PAD_PULL(pull) | PAD_IOSSTATE(iosstate)) +#define PAD_CFG_GPI_TRIG_IOSSTATE_OWN(pad, pull, rst, trig, iosstate, own) \ + _PAD_CFG_STRUCT(pad, \ + PAD_FUNC(GPIO) | PAD_RESET(rst) | PAD_TRIG(trig) | PAD_BUF(TX_DISABLE), \ + PAD_PULL(pull) | PAD_CFG_OWN_GPIO(own) | PAD_IOSSTATE(iosstate))
-#define PAD_CFG_GPI_IOSSTATE_IOSTERM(pad, pull, rst, iosstate, iosterm) \ - _PAD_CFG_STRUCT(pad, \ - PAD_FUNC(GPIO) | PAD_RESET(rst) | PAD_CFG0_TX_DISABLE, \ - PAD_PULL(pull) | PAD_IOSSTATE(iosstate) | PAD_IOSTERM(iosterm)) +#define PAD_CFG_GPI_TRIG_IOS_OWN(pad, pull, rst, trig, iosstate, iosterm, own) \ + _PAD_CFG_STRUCT(pad, \ + PAD_FUNC(GPIO) | PAD_RESET(rst) | PAD_TRIG(trig) | PAD_BUF(TX_DISABLE), \ + PAD_PULL(pull) | PAD_CFG_OWN_GPIO(own) | \ + PAD_IOSSTATE(iosstate) | PAD_IOSTERM(iosterm))
/* * General purpose input. The following macro sets the
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42911
to look at the new patch set (#3).
Change subject: soc/intel/common/gpio_defs: Improve some GPI macros ......................................................................
soc/intel/common/gpio_defs: Improve some GPI macros
The patch updates existing macros for the GPI:
- PAD_CFG_GPI_IOSSTATE_IOSTERM() - PAD_CFG_GPI_IOSSTATE()
to allow the user to set the RX Level/Edge Configuration (trig) and the Host Software Ownership (own) fileds in addition to IO Standby State (iosstate) and IO Standby Termination (iosterm) in the pad configuration using these macros.
Change-Id: I8a70a366e816d31720d341a5d26880dc32ff9b8d Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/soc/intel/common/block/include/intelblocks/gpio_defs.h 1 file changed, 9 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/42911/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42911 )
Change subject: soc/intel/common/gpio_defs: Improve some GPI macros ......................................................................
Patch Set 8: Code-Review+2
(1 comment)
These macros aren't used as of now, right?
https://review.coreboot.org/c/coreboot/+/42911/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42911/8//COMMIT_MSG@15 PS8, Line 15: fileds fields
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42911 )
Change subject: soc/intel/common/gpio_defs: Improve some GPI macros ......................................................................
Patch Set 8: Code-Review+1
Hello build bot (Jenkins), Nico Huber, Angel Pons, Michael Niewöhner, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42911
to look at the new patch set (#9).
Change subject: soc/intel/common/gpio_defs: Improve some GPI macros ......................................................................
soc/intel/common/gpio_defs: Improve some GPI macros
The patch updates existing macros for the GPI:
- PAD_CFG_GPI_IOSSTATE_IOSTERM() - PAD_CFG_GPI_IOSSTATE()
to allow the user to set the RX Level/Edge Configuration (trig) and the Host Software Ownership (own) fields in addition to IO Standby State (iosstate) and IO Standby Termination (iosterm) in the pad configuration using these macros.
Change-Id: I8a70a366e816d31720d341a5d26880dc32ff9b8d Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/soc/intel/common/block/include/intelblocks/gpio_defs.h 1 file changed, 9 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/42911/9
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42911 )
Change subject: soc/intel/common/gpio_defs: Improve some GPI macros ......................................................................
Patch Set 9:
(1 comment)
Patch Set 8: Code-Review+2
Thanks for the review
(1 comment)
These macros aren't used as of now, right?
Yes, there are no boards in the master that use these macros, but this is needed for CB:39765 https://review.coreboot.org/c/coreboot/+/39765/27/src/mainboard/up/squared/g...
and CB:39133 https://review.coreboot.org/c/coreboot/+/39133/33/src/mainboard/kontron/mal1...
https://review.coreboot.org/c/coreboot/+/42911/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42911/8//COMMIT_MSG@15 PS8, Line 15: fileds
fields
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42911 )
Change subject: soc/intel/common/gpio_defs: Improve some GPI macros ......................................................................
Patch Set 9: Code-Review+2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42911 )
Change subject: soc/intel/common/gpio_defs: Improve some GPI macros ......................................................................
Patch Set 9: Code-Review+2
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42911 )
Change subject: soc/intel/common/gpio_defs: Improve some GPI macros ......................................................................
soc/intel/common/gpio_defs: Improve some GPI macros
The patch updates existing macros for the GPI:
- PAD_CFG_GPI_IOSSTATE_IOSTERM() - PAD_CFG_GPI_IOSSTATE()
to allow the user to set the RX Level/Edge Configuration (trig) and the Host Software Ownership (own) fields in addition to IO Standby State (iosstate) and IO Standby Termination (iosterm) in the pad configuration using these macros.
Change-Id: I8a70a366e816d31720d341a5d26880dc32ff9b8d Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42911 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Michael Niewöhner --- M src/soc/intel/common/block/include/intelblocks/gpio_defs.h 1 file changed, 9 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Michael Niewöhner: Looks good to me, approved
diff --git a/src/soc/intel/common/block/include/intelblocks/gpio_defs.h b/src/soc/intel/common/block/include/intelblocks/gpio_defs.h index e9abd00..c2c8951 100644 --- a/src/soc/intel/common/block/include/intelblocks/gpio_defs.h +++ b/src/soc/intel/common/block/include/intelblocks/gpio_defs.h @@ -266,15 +266,16 @@ PAD_FUNC(GPIO) | PAD_RESET(rst) | PAD_BUF(TX_DISABLE), \ PAD_PULL(pull) | PAD_IOSSTATE(TxDRxE))
-#define PAD_CFG_GPI_IOSSTATE(pad, pull, rst, iosstate) \ - _PAD_CFG_STRUCT(pad, \ - PAD_FUNC(GPIO) | PAD_RESET(rst) | PAD_CFG0_TX_DISABLE, \ - PAD_PULL(pull) | PAD_IOSSTATE(iosstate)) +#define PAD_CFG_GPI_TRIG_IOSSTATE_OWN(pad, pull, rst, trig, iosstate, own) \ + _PAD_CFG_STRUCT(pad, \ + PAD_FUNC(GPIO) | PAD_RESET(rst) | PAD_TRIG(trig) | PAD_BUF(TX_DISABLE), \ + PAD_PULL(pull) | PAD_CFG_OWN_GPIO(own) | PAD_IOSSTATE(iosstate))
-#define PAD_CFG_GPI_IOSSTATE_IOSTERM(pad, pull, rst, iosstate, iosterm) \ - _PAD_CFG_STRUCT(pad, \ - PAD_FUNC(GPIO) | PAD_RESET(rst) | PAD_CFG0_TX_DISABLE, \ - PAD_PULL(pull) | PAD_IOSSTATE(iosstate) | PAD_IOSTERM(iosterm)) +#define PAD_CFG_GPI_TRIG_IOS_OWN(pad, pull, rst, trig, iosstate, iosterm, own) \ + _PAD_CFG_STRUCT(pad, \ + PAD_FUNC(GPIO) | PAD_RESET(rst) | PAD_TRIG(trig) | PAD_BUF(TX_DISABLE), \ + PAD_PULL(pull) | PAD_CFG_OWN_GPIO(own) | \ + PAD_IOSSTATE(iosstate) | PAD_IOSTERM(iosterm))
/* * General purpose input. The following macro sets the
-
Angel Pons (Code Review) -
Maxim Polyakov (Code Review)
-
Michael Niewöhner (Code Review)