Mathew King has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36043 )
Change subject: soc/intel/cannonlake: Add gfx.asl file ......................................................................
soc/intel/cannonlake: Add gfx.asl file
Add gfx.asl file for cannonlake SOCs to allow for graphics related ACPI devices and methods on cannonlake devices.
BUG=b:142237145 TEST=gfx.asl added to drallion dsdt.asl
Change-Id: I38a26f3135d571e2f9b63840d38fd4d3476fc142 Signed-off-by: Mathew King mathewk@chromium.org --- A src/soc/intel/cannonlake/acpi/gfx.asl 1 file changed, 20 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/36043/1
diff --git a/src/soc/intel/cannonlake/acpi/gfx.asl b/src/soc/intel/cannonlake/acpi/gfx.asl new file mode 100644 index 0000000..fef28f0 --- /dev/null +++ b/src/soc/intel/cannonlake/acpi/gfx.asl @@ -0,0 +1,20 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2019 Google LLC + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the + * GNU General Public License for more details. + */ + +Device (GFX0) +{ + Name (_ADR, 0x00020000) +} \ No newline at end of file
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36043
to look at the new patch set (#3).
Change subject: soc/intel/cannonlake: Add gfx.asl file ......................................................................
soc/intel/cannonlake: Add gfx.asl file
Add gfx.asl file for cannonlake SOCs to allow for graphics related ACPI devices and methods on cannonlake devices.
BUG=b:142237145 TEST=gfx.asl added to drallion dsdt.asl
Change-Id: I38a26f3135d571e2f9b63840d38fd4d3476fc142 Signed-off-by: Mathew King mathewk@chromium.org --- A src/soc/intel/cannonlake/acpi/gfx.asl 1 file changed, 20 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/36043/3
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36043
to look at the new patch set (#6).
Change subject: soc/intel/cannonlake: Add gfx.asl file ......................................................................
soc/intel/cannonlake: Add gfx.asl file
Add gfx.asl file for cannonlake SOCs to allow for graphics related ACPI devices and methods on cannonlake devices.
BUG=b:142237145 TEST=gfx.asl added to drallion dsdt.asl
Change-Id: I38a26f3135d571e2f9b63840d38fd4d3476fc142 Signed-off-by: Mathew King mathewk@chromium.org --- A src/soc/intel/cannonlake/acpi/gfx.asl 1 file changed, 20 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/36043/6
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36043
to look at the new patch set (#10).
Change subject: soc/intel/cannonlake: Add gfx.asl file ......................................................................
soc/intel/cannonlake: Add gfx.asl file
Add gfx.asl file for cannonlake SOCs to allow for graphics related ACPI devices and methods on cannonlake devices.
BUG=b:142237145 TEST=gfx.asl added to drallion dsdt.asl
Change-Id: I38a26f3135d571e2f9b63840d38fd4d3476fc142 Signed-off-by: Mathew King mathewk@chromium.org --- A src/soc/intel/cannonlake/acpi/gfx.asl 1 file changed, 20 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/36043/10
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36043 )
Change subject: soc/intel/cannonlake: Add gfx.asl file ......................................................................
Patch Set 10:
does this need to be #included somewhere?
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36043 )
Change subject: soc/intel/cannonlake: Add gfx.asl file ......................................................................
Patch Set 10:
Patch Set 10:
does this need to be #included somewhere?
I see it included in the last commit now. You could just #include it in northbridge.asl instead of needing to add it to the mainboard ASL.
Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36043 )
Change subject: soc/intel/cannonlake: Add gfx.asl file ......................................................................
Patch Set 10:
Patch Set 10:
Patch Set 10:
does this need to be #included somewhere?
I see it included in the last commit now. You could just #include it in northbridge.asl instead of needing to add it to the mainboard ASL.
northbridge or southbridge, should it always be included or based on some config flag?
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36043 )
Change subject: soc/intel/cannonlake: Add gfx.asl file ......................................................................
Patch Set 11:
Patch Set 10:
Patch Set 10:
Patch Set 10:
does this need to be #included somewhere?
I see it included in the last commit now. You could just #include it in northbridge.asl instead of needing to add it to the mainboard ASL.
northbridge or southbridge, should it always be included or based on some config flag?
Probably in northbridge, and it could be included always as it will get ignored if the PCI device doesn't exist.
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36043
to look at the new patch set (#12).
Change subject: soc/intel/cannonlake: Add gfx.asl file ......................................................................
soc/intel/cannonlake: Add gfx.asl file
Add gfx.asl file for cannonlake SOCs to allow for graphics related ACPI devices and methods on cannonlake devices.
BUG=b:142237145 TEST=gfx.asl added to drallion dsdt.asl
Change-Id: I38a26f3135d571e2f9b63840d38fd4d3476fc142 Signed-off-by: Mathew King mathewk@chromium.org --- A src/soc/intel/cannonlake/acpi/gfx.asl M src/soc/intel/cannonlake/acpi/southbridge.asl 2 files changed, 23 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/36043/12
Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36043 )
Change subject: soc/intel/cannonlake: Add gfx.asl file ......................................................................
Patch Set 12:
Patch Set 11:
Patch Set 10:
Patch Set 10:
Patch Set 10:
does this need to be #included somewhere?
I see it included in the last commit now. You could just #include it in northbridge.asl instead of needing to add it to the mainboard ASL.
northbridge or southbridge, should it always be included or based on some config flag?
Probably in northbridge, and it could be included always as it will get ignored if the PCI device doesn't exist.
The southbridge.asl file had other includes with PCI devices so I put it there. If there is a reason to move it to northbridge I will do that.
Simon Glass has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36043 )
Change subject: soc/intel/cannonlake: Add gfx.asl file ......................................................................
Patch Set 13: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/36043/13//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36043/13//COMMIT_MSG@9 PS13, Line 9: -
Hello Patrick Rudolph, Simon Glass, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36043
to look at the new patch set (#14).
Change subject: soc/intel/cannonlake: Add gfx.asl file ......................................................................
soc/intel/cannonlake: Add gfx.asl file
Add gfx.asl file for cannonlake SOCs to allow for graphics-related ACPI devices and methods on cannonlake devices.
BUG=b:142237145 TEST=gfx.asl added to drallion dsdt.asl
Change-Id: I38a26f3135d571e2f9b63840d38fd4d3476fc142 Signed-off-by: Mathew King mathewk@chromium.org --- A src/soc/intel/cannonlake/acpi/gfx.asl M src/soc/intel/cannonlake/acpi/southbridge.asl 2 files changed, 23 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/36043/14
Simon Glass has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36043 )
Change subject: soc/intel/cannonlake: Add gfx.asl file ......................................................................
Patch Set 14: Code-Review+2
Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36043 )
Change subject: soc/intel/cannonlake: Add gfx.asl file ......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36043/13//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36043/13//COMMIT_MSG@9 PS13, Line 9:
Done
Duncan Laurie has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36043 )
Change subject: soc/intel/cannonlake: Add gfx.asl file ......................................................................
soc/intel/cannonlake: Add gfx.asl file
Add gfx.asl file for cannonlake SOCs to allow for graphics-related ACPI devices and methods on cannonlake devices.
BUG=b:142237145 TEST=gfx.asl added to drallion dsdt.asl
Change-Id: I38a26f3135d571e2f9b63840d38fd4d3476fc142 Signed-off-by: Mathew King mathewk@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/36043 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Simon Glass sjg@chromium.org --- A src/soc/intel/cannonlake/acpi/gfx.asl M src/soc/intel/cannonlake/acpi/southbridge.asl 2 files changed, 23 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Simon Glass: Looks good to me, approved
diff --git a/src/soc/intel/cannonlake/acpi/gfx.asl b/src/soc/intel/cannonlake/acpi/gfx.asl new file mode 100644 index 0000000..d267859 --- /dev/null +++ b/src/soc/intel/cannonlake/acpi/gfx.asl @@ -0,0 +1,20 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2019 Google LLC + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the + * GNU General Public License for more details. + */ + +Device (GFX0) +{ + Name (_ADR, 0x00020000) +} diff --git a/src/soc/intel/cannonlake/acpi/southbridge.asl b/src/soc/intel/cannonlake/acpi/southbridge.asl index b52de65..8dbd850 100644 --- a/src/soc/intel/cannonlake/acpi/southbridge.asl +++ b/src/soc/intel/cannonlake/acpi/southbridge.asl @@ -31,6 +31,9 @@ #include "gpio.asl" #endif
+/* GFX 00:02.0 */ +#include "gfx.asl" + /* LPC 0:1f.0 */ #include <soc/intel/common/block/acpi/acpi/lpc.asl>
-
Duncan Laurie (Code Review) -
Mathew King (Code Review)
-
Simon Glass (Code Review)