Attention is currently required from: Arthur Heymans, Maximilian Brune, Philipp Hug.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68842?usp=email )
Change subject: lib/ramdetect: Limit probe size to function argument
......................................................................
Patch Set 7:
(2 comments)
File src/lib/ramdetect.c:
https://review.coreboot.org/c/coreboot/+/68842/comment/4457471b_d9e9723f :
PS7, Line 50: /* Find the MSB + 1. */
Wouldn't starting with MSB instead achieve the same?
https://review.coreboot.org/c/coreboot/+/68842/comment/d7ddb329_c13c0587 :
PS7, Line 54: } while (tmp >>= 1);
e.g. `--msb` here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68842?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie7f915c6e150629eff235ee94719172467a54db2
Gerrit-Change-Number: 68842
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 05 Feb 2024 19:48:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment