Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63171 )
Change subject: ec/starlabs/merlin: Remove comment about OPWE ......................................................................
ec/starlabs/merlin: Remove comment about OPWE
OPWE offset didn't exist, but it does now so remove the comment about this.
Signed-off-by: Sean Rhodes sean@starlabs.systems Change-Id: I4a1310c779002dfb00d01a22437ea223bb406609 Reviewed-on: https://review.coreboot.org/c/coreboot/+/63171 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/ec/starlabs/merlin/variants/apl/emem.asl M src/ec/starlabs/merlin/variants/cml/emem.asl M src/ec/starlabs/merlin/variants/glk/emem.asl M src/ec/starlabs/merlin/variants/glkr/emem.asl M src/ec/starlabs/merlin/variants/kbl/emem.asl M src/ec/starlabs/merlin/variants/merlin/emem.asl M src/ec/starlabs/merlin/variants/tgl/emem.asl 7 files changed, 0 insertions(+), 14 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/ec/starlabs/merlin/variants/apl/emem.asl b/src/ec/starlabs/merlin/variants/apl/emem.asl index d30b58c..af1fb27 100644 --- a/src/ec/starlabs/merlin/variants/apl/emem.asl +++ b/src/ec/starlabs/merlin/variants/apl/emem.asl @@ -98,10 +98,8 @@ BT1T, 16, // Bt1 Temperature BT1C, 8, // Bt1 Control
- // Unicorn - doesn't actually exist Offset(0x9d), OPWE, 8, // OPM write to EC flag for UCSI - // Unicorn - doesn't actually exist
Offset(0xbf), EJ8A, 8, // EJ898A Firmware Version diff --git a/src/ec/starlabs/merlin/variants/cml/emem.asl b/src/ec/starlabs/merlin/variants/cml/emem.asl index 97845cd..b6a3c7b 100644 --- a/src/ec/starlabs/merlin/variants/cml/emem.asl +++ b/src/ec/starlabs/merlin/variants/cml/emem.asl @@ -108,10 +108,8 @@ BT1T, 16, // Bt1 Temperature BT1C, 8, // Bt1 Control
- // Unicorn - doesn't actually exist Offset(0x9d), OPWE, 8, // OPM write to EC flag for UCSI - // Unicorn - doesn't actually exist
Offset(0xa0), UCSV, 16, // UCSI DS Version diff --git a/src/ec/starlabs/merlin/variants/glk/emem.asl b/src/ec/starlabs/merlin/variants/glk/emem.asl index 9173745..c41fc24 100644 --- a/src/ec/starlabs/merlin/variants/glk/emem.asl +++ b/src/ec/starlabs/merlin/variants/glk/emem.asl @@ -98,10 +98,8 @@ BT1T, 16, // Bt1 Temperature BT1C, 8, // Bt1 Control
- // Unicorn - doesn't actually exist Offset(0x9d), OPWE, 8, // OPM write to EC flag for UCSI - // Unicorn - doesn't actually exist
Offset(0xbf), EJ8A, 8, // EJ898A Firmware Version diff --git a/src/ec/starlabs/merlin/variants/glkr/emem.asl b/src/ec/starlabs/merlin/variants/glkr/emem.asl index d591358..4f7c100 100644 --- a/src/ec/starlabs/merlin/variants/glkr/emem.asl +++ b/src/ec/starlabs/merlin/variants/glkr/emem.asl @@ -69,10 +69,8 @@ BT1T, 16, // Bt1 Temperature BT1C, 8, // Bt1 Control
- // Unicorn - doesn't actually exist Offset(0x9d), OPWE, 8, // OPM write to EC flag for UCSI - // Unicorn - doesn't actually exist
Offset(0xa0), BSNL, 8, // Battery Serial Number Low byte diff --git a/src/ec/starlabs/merlin/variants/kbl/emem.asl b/src/ec/starlabs/merlin/variants/kbl/emem.asl index 6669917..5532206 100644 --- a/src/ec/starlabs/merlin/variants/kbl/emem.asl +++ b/src/ec/starlabs/merlin/variants/kbl/emem.asl @@ -85,10 +85,8 @@ BPRP, 8, // Battery Remaining percentage BT1A, 8, // Bt1 ASOC
- // Unicorn - doesn't actually exist Offset(0x9d), OPWE, 8, // OPM write to EC flag for UCSI - // Unicorn - doesn't actually exist
Offset(0xbf), EJ8A, 8, // EJ898A Firmware Version diff --git a/src/ec/starlabs/merlin/variants/merlin/emem.asl b/src/ec/starlabs/merlin/variants/merlin/emem.asl index 06749f0..45958fe 100644 --- a/src/ec/starlabs/merlin/variants/merlin/emem.asl +++ b/src/ec/starlabs/merlin/variants/merlin/emem.asl @@ -91,10 +91,8 @@ BATT, 16, // Battery Temperature BATC, 8, // Battery Temperature Ces
- // Unicorn - doesn't actually exist Offset(0x9d), // OPM: OPWE, 8, // OPM write to EC flag for UCSI - // Unicorn - doesn't actually exist
Offset(0xb0), // MGO; MGO0, 8, // UCSI DS MGO 0 diff --git a/src/ec/starlabs/merlin/variants/tgl/emem.asl b/src/ec/starlabs/merlin/variants/tgl/emem.asl index 09ddc4d..7c9c0ed 100644 --- a/src/ec/starlabs/merlin/variants/tgl/emem.asl +++ b/src/ec/starlabs/merlin/variants/tgl/emem.asl @@ -98,10 +98,8 @@ B1PV, 16, // Battery Present Voltage BPRP, 8, // Battery Remaining percentage
- // Unicorn - doesn't actually exist Offset(0x9d), OPWE, 8, // OPM write to EC flag for UCSI - // Unicorn - doesn't actually exist
Offset(0xb0), MGO0, 8, // UCSI DS MGO 0
-
Felix Held (Code Review)