Attention is currently required from: Henry Sun, Frank Chu, Zhuohao Lee, Karthik Ramasubramanian. Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58734 )
Change subject: mb/google/dedede/var/galtic: update Wifi SAR for convertibles ......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/dedede/variants/galtic/variant.c:
https://review.coreboot.org/c/coreboot/+/58734/comment/c74f4ba8_16ae4f8a PS5, Line 32: "wifi_sar-galith.hex"
If this case happens, i would suggest to return WIFI_SAR_CBFS_DEFAULT_FILENAME instead of "wifi_sar- […]
I didn't follow wifi sar cbfs file closely already but I found that config - CONFIG_WIFI_SAR_CBFS_FILEPATH is defined as "" in [1].
And it looks like the config above will be used as wifi_sar_defaults.hex path [2]. In the end, WIFI_SAR_CBFS_DEFAULT_FILENAME is defined as wifi_sar_defaults.hex in sar.h.
As a result, if we return WIFI_SAR_CBFS_DEFAULT_FILENAME then there will be no sar table be returned?
On the other hand, if there is no SKU which don't need any SAR table then we should not define CONFIG_WIFI_SAR_CBFS_FILEPATH to "" but wifi_sar-galith.hex in this case.
[1] https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/r... [2] https://chromium.googlesource.com/chromiumos/third_party/coreboot/+/refs/hea...