Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34724 )
Change subject: soc/intel/common: Implement power-failure-state handling
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34724/4/src/soc/intel/common/block/...
File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/34724/4/src/soc/intel/common/block/...
PS4, Line 602: state == MAINBOARD_POWER_STATE_ON
For the moment, yes. I tried to keep it close to the current behavior […]
Current behavior is if CONFIG_MAINBOARD_POWER_FAILURE_STATE is set to MAINBOARD_POWER_STATE_PREVIOUS, then the code just leaves the AFTERG3 bit untouched. But, I see that the meaning of MAINBOARD_POWER_STATE_PREVIOUS isn't supposed to be that based on CB:34728.
It makes sense to squash the two CLs together since it is easier to see what the overall logic is.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34724
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6970a79d9b95373c2855f4c92232d2aa05963bb
Gerrit-Change-Number: 34724
Gerrit-PatchSet: 4
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 07 Aug 2019 21:16:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment