Change in coreboot[master]: amd/cezanne: adding support for the changed AMD FSP API for USB PHY
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Matt Papageorge, Julian Schroeder, Felix Held. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54065 )
Change subject: amd/cezanne: adding support for the changed AMD FSP API for USB PHY ......................................................................
Patch Set 6:
(4 comments)
File src/soc/amd/cezanne/fsp_m_params.c:
https://review.coreboot.org/c/coreboot/+/54065/comment/c820ba7d_eead333a PS6, Line 132: coreboot uses tabs for indenting. Here and line 135.
File src/vendorcode/amd/fsp/cezanne/FspUsb.h:
https://review.coreboot.org/c/coreboot/+/54065/comment/b4be2cfb_db7753b3 PS6, Line 11: uint8_t compdstune; ///< COMPDSTUNE Use tabs to indent all these
https://review.coreboot.org/c/coreboot/+/54065/comment/8e1d9ec3_da23004e PS6, Line 12: uint8_t sqrxtune; ///< SQRXTUNE : uint8_t txfslstune; ///< TXFSLSTUNE : uint8_t txpreempamptune; ///< TXPREEMPAMPTUNE : uint8_t txpreemppulsetune; ///< TXPREEMPPULSETUNE : uint8_t txrisetune; ///< TXRISETUNE : uint8_t txvreftune; ///< TXVREFTUNE : uint8_t txhsxvtune; ///< TXHSXVTUNE : uint8_t txrestune; ///< TXRESTUNE Remove Windows line endings from these. Run "make gitconfig" to catch these ahead of time with a commit hook.
https://review.coreboot.org/c/coreboot/+/54065/comment/051e3e33_aa9d7ac0 PS6, Line 23: uint8_t tx_term_ctrl; ///< tx_term_ctrl : uint8_t rx_term_ctrl; ///< rx_term_ctrl : uint8_t tx_vboost_lvl_en; ///< TX_VBOOST_LVL_EN : uint8_t tx_vboost_lvl; ///< TX_VBOOST_LVL Remove Windows line endings from these.
-
Marshall Dawson (Code Review)