Attention is currently required from: Angel Pons, Arthur Heymans, Julius Werner, Maximilian Brune, Philipp Hug, Ron Minnich.
Nico Huber has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/81910?usp=email )
Change subject: commonlib/bsd/lz4_wrapper.c: Fix misaligned access
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
File src/commonlib/bsd/lz4_wrapper.c:
https://review.coreboot.org/c/coreboot/+/81910/comment/564fbf68_4f4ee0e9?usp... :
PS5, Line 10: /* LZ4 comes with its own supposedly portable memory access functions, but they
: * seem to be very inefficient in practice (at least on ARM64). Since coreboot
: * knows about endianness and allows some basic assumptions (such as unaligned
: * access support), we can easily write the ones we need ourselves. */
They now reflect the discussions in the comments.
I have a feeling that the orginal comment meant to include LZ4_copy8().
I don't mind the change, though. Seems less complicated than having to
guess what a comment applies to exactly.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81910?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id165829bfd35be2bce2bbb019c208a304f627add
Gerrit-Change-Number: 81910
Gerrit-PatchSet: 6
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Ron Minnich
rminnich@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Ron Minnich
rminnich@gmail.com
Gerrit-Comment-Date: Sun, 30 Jun 2024 09:05:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com