Attention is currently required from: Felix Singer, Sean Rhodes, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58798 )
Change subject: soc/intel/tigerlake/apci: Only use SCM for ChromeOS
......................................................................
Patch Set 9: Code-Review+2
(3 comments)
Patchset:
PS5:
Unfortunately, this has turned out to be Part 1 of 2 as D3cold is refusing to turn off. […]
To be clear: you are trying to disable d3cold support for the TBT ports?
Patchset:
PS9:
Alder Lake might need doing, don't have on to test though..
Very likely, the TBT support is basically the same.
PS9:
Seems OK for now, but let's keep an eye on how many different "configuration" options we need in this file... we may want to add new Kconfig options instead of CHROMEOS everywhere.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58798
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib947c3c9cd843e54d4664509c15336178c0bc99e
Gerrit-Change-Number: 58798
Gerrit-PatchSet: 9
Gerrit-Owner: Sean Rhodes
admin@starlabs.systems
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Andy Pont
andy.pont@sdcsystems.com
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Sean Rhodes
admin@starlabs.systems
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 04 Nov 2021 19:28:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Sean Rhodes
admin@starlabs.systems
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment