Attention is currently required from: Zhi7 Li, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56930 )
Change subject: mb/google/dedede/var/sasukette: Codec ALC5682I-VD & VS compatibility
......................................................................
Patch Set 7:
(2 comments)
Patchset:
PS1:
Thanks a lot for your advise, I have verified that ALC5682I-VD or VS audio codec can both work norma […]
👍 great!
File src/mainboard/google/dedede/variants/sasukette/ramstage.c:
https://review.coreboot.org/c/coreboot/+/56930/comment/4ca2fd6a_218ff5bb
PS6, Line 19: codec_path, ARRAY_SIZE(codec_path));
Thanks very much for your detail reminding and comment which have really teach me a lot of how to ap […]
Line lengths in coreboot are 96 wide, so feel free to use the whole width, or break it up into multiple lines if required.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56930
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8840454e4934162ea59c742634a56f70b153238
Gerrit-Change-Number: 56930
Gerrit-PatchSet: 7
Gerrit-Owner: Zhi7 Li
lizhi7@huaqin.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Zhi7 Li
lizhi7@huaqin.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Sun, 15 Aug 2021 02:04:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Zhi7 Li
lizhi7@huaqin.corp-partner.google.com
Gerrit-MessageType: comment