Attention is currently required from: Raul Rangel, Kangheui Won, Felix Held.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55136 )
Change subject: mb/google/guybrush: initialize i2c in psp_verstage
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/guybrush/verstage.c:
https://review.coreboot.org/c/coreboot/+/55136/comment/8d03815e_5124e961
PS1, Line 28: if (CONFIG(VBOOT_STARTS_BEFORE_BOOTBLOCK)) {
: enable_aoac_devices();
: printk(BIOS_DEBUG, "Setting up i2c\n");
: i2c_soc_early_init();
: printk(BIOS_DEBUG, "i2c setup\n");
: }
I think this should be done as part of `verstage_soc_init()` and not mainboard init. It is similar to how i2c early init and other inits are performed in bootblock and/or other stages.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55136
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f7b73be67a692ea7de31ae53bd111d0e4b6998c
Gerrit-Change-Number: 55136
Gerrit-PatchSet: 1
Gerrit-Owner: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 02 Jun 2021 19:38:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment