EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39353 )
Change subject: lib/spd_bin: Tweak the log ......................................................................
lib/spd_bin: Tweak the log
Correct the missing log. Should be the part number not just part.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I17ac9c6f9545d84645665d3abe1d1613baef4e14 --- M src/lib/spd_bin.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/39353/1
diff --git a/src/lib/spd_bin.c b/src/lib/spd_bin.c index e4a282f..58c23f6 100644 --- a/src/lib/spd_bin.c +++ b/src/lib/spd_bin.c @@ -177,7 +177,7 @@ /* Module Part Number */ spd_get_name(spd, spd_name, type);
- printk(BIOS_INFO, "SPD: module part is %s\n", spd_name); + printk(BIOS_INFO, "SPD: module part number is %s\n", spd_name);
printk(BIOS_INFO, "SPD: banks %d, ranks %d, rows %d, columns %d, density %d Mb\n",
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39353 )
Change subject: lib/spd_bin: Tweak the log ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/39353/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39353/1//COMMIT_MSG@7 PS1, Line 7: lib/spd_bin: Tweak the log Add *number* to log message
Hello build bot (Jenkins), Furquan Shaikh, Paul Menzel, Duncan Laurie,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39353
to look at the new patch set (#2).
Change subject: lib/spd_bin: Add *number* to log message ......................................................................
lib/spd_bin: Add *number* to log message
Correct the missing log. Should be the part number not just part.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I17ac9c6f9545d84645665d3abe1d1613baef4e14 --- M src/lib/spd_bin.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/39353/2
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39353 )
Change subject: lib/spd_bin: Add *number* to log message ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39353/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39353/1//COMMIT_MSG@7 PS1, Line 7: lib/spd_bin: Tweak the log
Add *number* to log message
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39353 )
Change subject: lib/spd_bin: Add *number* to log message ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/39353/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39353/2//COMMIT_MSG@7 PS2, Line 7: *number* Paul used the ** to highlight the word. Maybe use quotes instead?
lib/spd_bin: Add "number" to log message
Hello build bot (Jenkins), Furquan Shaikh, Paul Menzel, Duncan Laurie, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39353
to look at the new patch set (#3).
Change subject: lib/spd_bin: Add "number" to log message ......................................................................
lib/spd_bin: Add "number" to log message
Correct the missing log. Should be the part number not just part.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I17ac9c6f9545d84645665d3abe1d1613baef4e14 --- M src/lib/spd_bin.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/39353/3
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39353 )
Change subject: lib/spd_bin: Add "number" to log message ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39353/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39353/2//COMMIT_MSG@7 PS2, Line 7: *number*
Paul used the ** to highlight the word. Maybe use quotes instead? […]
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39353 )
Change subject: lib/spd_bin: Add "number" to log message ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39353/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39353/2//COMMIT_MSG@7 PS2, Line 7: *number*
Done
Thanks!
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39353 )
Change subject: lib/spd_bin: Add "number" to log message ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39353 )
Change subject: lib/spd_bin: Add "number" to log message ......................................................................
lib/spd_bin: Add "number" to log message
Correct the missing log. Should be the part number not just part.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I17ac9c6f9545d84645665d3abe1d1613baef4e14 Reviewed-on: https://review.coreboot.org/c/coreboot/+/39353 Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/lib/spd_bin.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Furquan Shaikh: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/lib/spd_bin.c b/src/lib/spd_bin.c index 4bf77d2..84e2123 100644 --- a/src/lib/spd_bin.c +++ b/src/lib/spd_bin.c @@ -177,7 +177,7 @@ /* Module Part Number */ spd_get_name(spd, spd_name, type);
- printk(BIOS_INFO, "SPD: module part is %s\n", spd_name); + printk(BIOS_INFO, "SPD: module part number is %s\n", spd_name);
printk(BIOS_INFO, "SPD: banks %d, ranks %d, rows %d, columns %d, density %d Mb\n",
-
Angel Pons (Code Review) -
EricR Lai (Code Review)
-
Furquan Shaikh (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)