Change in coreboot[master]: smbios: Create a type for smbios_enclosure_type

[Mathew King (Code Review)]

Mathew King has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36516 )

Change subject: smbios: Create a type for smbios_enclosure_type
......................................................................

smbios: Create a type for smbios_enclosure_type

Add a name to the SMBIOS enclosure type enum and use it as the return
type for smbios_mainboard_enclosure_type.

BUG=b:143701965
TEST=compiles

Change-Id: I816e17f0de2b0c119ddab638e57b0652f53f5b61
Signed-off-by: Mathew King 
---
M src/arch/x86/smbios.c
M src/include/smbios.h
2 files changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/36516/1

diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c
index 5edf3c6..261888f 100644
--- a/src/arch/x86/smbios.c
+++ b/src/arch/x86/smbios.c
@@ -492,7 +492,7 @@
    return SMBIOS_BOARD_TYPE_UNKNOWN;
 }

-u8 __weak smbios_mainboard_enclosure_type(void)
+smbios_enclosure_type __weak smbios_mainboard_enclosure_type(void)
 {
    return CONFIG_SMBIOS_ENCLOSURE_TYPE;
 }
diff --git a/src/include/smbios.h b/src/include/smbios.h
index ef1c7de..d230fb2 100644
--- a/src/include/smbios.h
+++ b/src/include/smbios.h
@@ -65,7 +65,6 @@
 const char *smbios_mainboard_asset_tag(void);
 u8 smbios_mainboard_feature_flags(void);
 const char *smbios_mainboard_location_in_chassis(void);
-u8 smbios_mainboard_enclosure_type(void);

#define BIOS_CHARACTERISTICS_PCI_SUPPORTED	(1 << 7)
 #define BIOS_CHARACTERISTICS_PC_CARD		(1 << 8)
@@ -319,7 +318,7 @@
    u8 eos[2];
 } __packed;

-enum {
+typedef enum {
    SMBIOS_ENCLOSURE_OTHER = 0x01,
    SMBIOS_ENCLOSURE_UNKNOWN = 0x02,
    SMBIOS_ENCLOSURE_DESKTOP = 0x03,
@@ -356,7 +355,7 @@
    SMBIOS_ENCLOSURE_EMBEDDED_PC = 0x22,
    SMBIOS_ENCLOSURE_MINI_PC = 0x23,
    SMBIOS_ENCLOSURE_STICK_PC = 0x24,
-};
+} smbios_enclosure_type;

struct smbios_type3 {
    u8 type;
@@ -798,5 +797,6 @@
    struct smbios_type17 *t);

smbios_board_type smbios_mainboard_board_type(void);
+smbios_enclosure_type smbios_mainboard_enclosure_type(void);

#endif

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36516 )

Change subject: smbios: Create a type for smbios_enclosure_type
......................................................................

Patch Set 1: Code-Review+2

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36516 )

Change subject: smbios: Create a type for smbios_enclosure_type
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36516 )

Change subject: smbios: Create a type for smbios_enclosure_type
......................................................................

smbios: Create a type for smbios_enclosure_type

Add a name to the SMBIOS enclosure type enum and use it as the return
type for smbios_mainboard_enclosure_type.

BUG=b:143701965
TEST=compiles

Change-Id: I816e17f0de2b0c119ddab638e57b0652f53f5b61
Signed-off-by: Mathew King 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36516
Reviewed-by: Patrick Georgi 
Reviewed-by: EricR Lai 
Tested-by: build bot (Jenkins) 
---
M src/arch/x86/smbios.c
M src/include/smbios.h
2 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved
  EricR Lai: Looks good to me, approved

diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c
index 5edf3c6..261888f 100644
--- a/src/arch/x86/smbios.c
+++ b/src/arch/x86/smbios.c
@@ -492,7 +492,7 @@
    return SMBIOS_BOARD_TYPE_UNKNOWN;
 }

-u8 __weak smbios_mainboard_enclosure_type(void)
+smbios_enclosure_type __weak smbios_mainboard_enclosure_type(void)
 {
    return CONFIG_SMBIOS_ENCLOSURE_TYPE;
 }
diff --git a/src/include/smbios.h b/src/include/smbios.h
index ef1c7de..d230fb2 100644
--- a/src/include/smbios.h
+++ b/src/include/smbios.h
@@ -65,7 +65,6 @@
 const char *smbios_mainboard_asset_tag(void);
 u8 smbios_mainboard_feature_flags(void);
 const char *smbios_mainboard_location_in_chassis(void);
-u8 smbios_mainboard_enclosure_type(void);

#define BIOS_CHARACTERISTICS_PCI_SUPPORTED	(1 << 7)
 #define BIOS_CHARACTERISTICS_PC_CARD		(1 << 8)
@@ -319,7 +318,7 @@
    u8 eos[2];
 } __packed;

-enum {
+typedef enum {
    SMBIOS_ENCLOSURE_OTHER = 0x01,
    SMBIOS_ENCLOSURE_UNKNOWN = 0x02,
    SMBIOS_ENCLOSURE_DESKTOP = 0x03,
@@ -356,7 +355,7 @@
    SMBIOS_ENCLOSURE_EMBEDDED_PC = 0x22,
    SMBIOS_ENCLOSURE_MINI_PC = 0x23,
    SMBIOS_ENCLOSURE_STICK_PC = 0x24,
-};
+} smbios_enclosure_type;

struct smbios_type3 {
    u8 type;
@@ -798,5 +797,6 @@
    struct smbios_type17 *t);

smbios_board_type smbios_mainboard_board_type(void);
+smbios_enclosure_type smbios_mainboard_enclosure_type(void);

#endif