Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Rob Barnes. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61259 )
Change subject: soc/amd/cezanne: Turn off gpp clock request for disabled devices ......................................................................
Patch Set 7:
(15 comments)
File src/soc/amd/cezanne/fch.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139821): https://review.coreboot.org/c/coreboot/+/61259/comment/002dd04a_77ffd724 PS7, Line 171: if (dxio_desc->engine_type != PCIE_ENGINE && dxio_desc->engine_type != UNUSED_ENGINE) line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139821): https://review.coreboot.org/c/coreboot/+/61259/comment/45ae762e_036ead92 PS7, Line 186: printk(BIOS_WARNING, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139821): https://review.coreboot.org/c/coreboot/+/61259/comment/1c70e41d_c57e2dcc PS7, Line 187: "Cannot find PCIe device %d.%d, disabling GPP clk req %d, DXIO descriptor %d\n", code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139821): https://review.coreboot.org/c/coreboot/+/61259/comment/a916a6d1_19a30f0b PS7, Line 187: "Cannot find PCIe device %d.%d, disabling GPP clk req %d, DXIO descriptor %d\n", please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139821): https://review.coreboot.org/c/coreboot/+/61259/comment/f72517f2_d705e75c PS7, Line 188: dxio_desc->device_number, dxio_desc->function_number, i, gpp_req_index); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139821): https://review.coreboot.org/c/coreboot/+/61259/comment/1e4bd6b9_0148e7c2 PS7, Line 188: dxio_desc->device_number, dxio_desc->function_number, i, gpp_req_index); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139821): https://review.coreboot.org/c/coreboot/+/61259/comment/60f8b1f8_33ac2a3e PS7, Line 188: dxio_desc->device_number, dxio_desc->function_number, i, gpp_req_index); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139821): https://review.coreboot.org/c/coreboot/+/61259/comment/52529eae_9050b711 PS7, Line 192: /* Check for mismatches between disabled devices and SoC gpp_clk_config. */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139821): https://review.coreboot.org/c/coreboot/+/61259/comment/5cd34609_a859c0bb PS7, Line 193: if (!pci_device->enabled && cfg->gpp_clk_config[gpp_req_index] != GPP_CLK_OFF) { line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139821): https://review.coreboot.org/c/coreboot/+/61259/comment/02e4e503_92595b33 PS7, Line 198: /* trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139821): https://review.coreboot.org/c/coreboot/+/61259/comment/769212dc_e3a837e0 PS7, Line 201: * by something other than a probe. trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139821): https://review.coreboot.org/c/coreboot/+/61259/comment/677ab328_7e41bb0e PS7, Line 203: printk(BIOS_WARNING, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139821): https://review.coreboot.org/c/coreboot/+/61259/comment/5ac9c34e_2fcb75a8 PS7, Line 205: dxio_desc->device_number, dxio_desc->function_number, gpp_req_index, i); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139821): https://review.coreboot.org/c/coreboot/+/61259/comment/6aaf385c_13cf9817 PS7, Line 209: dxio_desc->device_number, dxio_desc->function_number, gpp_req_index, i); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139821): https://review.coreboot.org/c/coreboot/+/61259/comment/50cba5b5_b0554357 PS7, Line 216: gpp_clk_ctl &= ~GPP_CLK_REQ_MASK(gpp_clk_shift_lut[i]); trailing whitespace