Hello Akshu Agrawal,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/44009
to review the following change.
Change subject: mb/google/zork: set is_rv to 1 for RV family ......................................................................
mb/google/zork: set is_rv to 1 for RV family
RV has difference in clk framework. To differentiate set the fmw property to 1 for boards using RV family of SoC.
Signed-off-by: Akshu Agrawal akshu.agrawal@amd.com
BUG=b:158906189 TEST=rt5682 driver get the correct clk and tested audio playback
Change-Id: I685ded1607c2c7edc5e48f0bada258ebde192bb8 --- M src/soc/amd/picasso/acpi/sb_fch.asl 1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/44009/1
diff --git a/src/soc/amd/picasso/acpi/sb_fch.asl b/src/soc/amd/picasso/acpi/sb_fch.asl index 7623d9b..4eca52c 100644 --- a/src/soc/amd/picasso/acpi/sb_fch.asl +++ b/src/soc/amd/picasso/acpi/sb_fch.asl @@ -352,6 +352,14 @@ Name (_CRS, ResourceTemplate() { Memory32Fixed (ReadWrite, ACPIMMIO_MISC_BASE, 0x100) }) + Name (_DSD, Package () + { + ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), + Package () + { + Package () { "is-rv", 1 }, + }, + }) Method (_STA, 0x0, NotSerialized) { Return (0x0F)
Akshu Agrawal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44009 )
Change subject: mb/google/zork: set is_rv to 1 for RV family ......................................................................
Patch Set 1:
https://patchwork.kernel.org/patch/11688663/
Akshu Agrawal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44009 )
Change subject: mb/google/zork: set is_rv to 1 for RV family ......................................................................
Patch Set 1:
Patch Set 1:
kernel patch recv. the property
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44009 )
Change subject: mb/google/zork: set is_rv to 1 for RV family ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44009/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44009/1//COMMIT_MSG@7 PS1, Line 7: mb/google/zork soc/amd/picasso:
https://review.coreboot.org/c/coreboot/+/44009/1//COMMIT_MSG@10 PS1, Line 10: fmw property to 1 for boards using RV family of SoC. Could you please elaborate on what we're differentiating against?
Hello build bot (Jenkins), Furquan Shaikh, Akshu Agrawal, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44009
to look at the new patch set (#2).
Change subject: soc/amd/picasso: set is_rv to 1 for RV family ......................................................................
soc/amd/picasso: set is_rv to 1 for RV family
RV has difference in clk framework. In RV we get a 48Mhz fixed clk, while in ST we had 25Mhz, 48mhz clocks and a Mux to select between them. To differentiate set the fmw property to 1 for boards using RV family of SoC.
Signed-off-by: Akshu Agrawal akshu.agrawal@amd.com
BUG=b:158906189 TEST=rt5682 driver get the correct clk and tested audio playback
Change-Id: I685ded1607c2c7edc5e48f0bada258ebde192bb8 --- M src/soc/amd/picasso/acpi/sb_fch.asl 1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/44009/2
Akshu Agrawal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44009 )
Change subject: soc/amd/picasso: set is_rv to 1 for RV family ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44009/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44009/1//COMMIT_MSG@7 PS1, Line 7: mb/google/zork
soc/amd/picasso:
Done
https://review.coreboot.org/c/coreboot/+/44009/1//COMMIT_MSG@10 PS1, Line 10: fmw property to 1 for boards using RV family of SoC.
Could you please elaborate on what we're differentiating against?
In RV we get a 48Mhz fixed clk, while in ST we had 25Mhz, 48mhz clocks and a Mux to select between them. Added the same in commit message.
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44009 )
Change subject: soc/amd/picasso: set is_rv to 1 for RV family ......................................................................
Patch Set 2: Code-Review+2
Aaron Durbin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44009 )
Change subject: soc/amd/picasso: set is_rv to 1 for RV family ......................................................................
soc/amd/picasso: set is_rv to 1 for RV family
RV has difference in clk framework. In RV we get a 48Mhz fixed clk, while in ST we had 25Mhz, 48mhz clocks and a Mux to select between them. To differentiate set the fmw property to 1 for boards using RV family of SoC.
Signed-off-by: Akshu Agrawal akshu.agrawal@amd.com
BUG=b:158906189 TEST=rt5682 driver get the correct clk and tested audio playback
Change-Id: I685ded1607c2c7edc5e48f0bada258ebde192bb8 Reviewed-on: https://review.coreboot.org/c/coreboot/+/44009 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aaron Durbin adurbin@chromium.org --- M src/soc/amd/picasso/acpi/sb_fch.asl 1 file changed, 8 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved
diff --git a/src/soc/amd/picasso/acpi/sb_fch.asl b/src/soc/amd/picasso/acpi/sb_fch.asl index 7623d9b..4eca52c 100644 --- a/src/soc/amd/picasso/acpi/sb_fch.asl +++ b/src/soc/amd/picasso/acpi/sb_fch.asl @@ -352,6 +352,14 @@ Name (_CRS, ResourceTemplate() { Memory32Fixed (ReadWrite, ACPIMMIO_MISC_BASE, 0x100) }) + Name (_DSD, Package () + { + ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), + Package () + { + Package () { "is-rv", 1 }, + }, + }) Method (_STA, 0x0, NotSerialized) { Return (0x0F)
-
Aaron Durbin (Code Review) -
Akshu Agrawal (Code Review)