Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39732 )
Change subject: util/inteltool: introduce common code lib ......................................................................
Patch Set 2:
(7 comments)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/39732/1/util/inteltool/common.c File util/inteltool/common.c:
https://review.coreboot.org/c/coreboot/+/39732/1/util/inteltool/common.c@40 PS1, Line 40: printf("0x%04x: 0x%08x (%s)\n" : " 0x%08x\n", : registers[i].addr, : pci_read_long(dev, registers[i].addr), : registers[i].name, : pci_read_long(dev, registers[i].addr + 4)); : break;
how about: […]
Done
https://review.coreboot.org/c/coreboot/+/39732/1/util/inteltool/common.c@48 PS1, Line 48: printf("0x%04x: 0x%08x (%s)\n", : registers[i].addr, : pci_read_long(dev, registers[i].addr), : registers[i].name);
static void print_reg32(const uint16_t addr, const uint32_t reg, const char *name)
Done
https://review.coreboot.org/c/coreboot/+/39732/1/util/inteltool/common.c@54 PS1, Line 54: printf("0x%04x: 0x%04x (%s)\n", : registers[i].addr, : pci_read_word(dev, registers[i].addr), : registers[i].name);
static void print_reg16(const uint16_t addr, const uint16_t reg, const char *name)
Done
https://review.coreboot.org/c/coreboot/+/39732/1/util/inteltool/common.c@60 PS1, Line 60: printf("0x%04x: 0x%02x (%s)\n", : registers[i].addr, : pci_read_byte(dev, registers[i].addr), : registers[i].name);
static void print_reg8(const uint16_t addr, const uint8_t reg, const char *name)
Done
https://review.coreboot.org/c/coreboot/+/39732/1/util/inteltool/common.c@83 PS1, Line 83: mmio_size
why should it? there is no need to
Done
https://review.coreboot.org/c/coreboot/+/39732/1/util/inteltool/common.c@83 PS1, Line 83: -1
Why are there no spaces?
Done
https://review.coreboot.org/c/coreboot/+/39732/1/util/inteltool/common.c@86 PS1, Line 86: USBBASE
really?
Done
-
Michael Niewöhner (Code Review)