Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47312 )
Change subject: commonlib: Add timestamp values for forced delays. ......................................................................
commonlib: Add timestamp values for forced delays.
Add a timestamp entry to allow forced delays to to be seen and accounted for in the timestamp data.
BUG=None TEST=Build only
Signed-off-by: Martin Roth martinroth@chromium.org Change-Id: I26c9fa5c8599a349de2631ac24b9ea8858d8d6c8 --- M src/commonlib/include/commonlib/timestamp_serialized.h 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/47312/1
diff --git a/src/commonlib/include/commonlib/timestamp_serialized.h b/src/commonlib/include/commonlib/timestamp_serialized.h index dd352ad..a572150 100644 --- a/src/commonlib/include/commonlib/timestamp_serialized.h +++ b/src/commonlib/include/commonlib/timestamp_serialized.h @@ -52,6 +52,8 @@ TS_SELFBOOT_JUMP = 99, TS_START_POSTCAR = 100, TS_END_POSTCAR = 101, + TS_DELAY_START = 110, + TS_DELAY_END = 111,
/* 500+ reserved for vendorcode extensions (500-600: google/chromeos) */ TS_START_COPYVER = 501, @@ -177,6 +179,8 @@ { TS_LOAD_PAYLOAD, "load payload" }, { TS_ACPI_WAKE_JUMP, "ACPI wake jump" }, { TS_SELFBOOT_JUMP, "selfboot jump" }, + { TS_DELAY_START, "Forced delay start" }, + { TS_DELAY_END, "Forced delay end" },
{ TS_START_COPYVER, "starting to load verstage" }, { TS_END_COPYVER, "finished loading verstage" },
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47312 )
Change subject: commonlib: Add timestamp values for forced delays. ......................................................................
Patch Set 2: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47312 )
Change subject: commonlib: Add timestamp values for forced delays. ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47312/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47312/2//COMMIT_MSG@7 PS2, Line 7: commonlib: Add timestamp values for forced delays. Nit: Please remove the dot/period at the end of the git commit message summary.
Hello build bot (Jenkins), Arthur Heymans,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47312
to look at the new patch set (#3).
Change subject: commonlib: Add timestamp values for forced delays ......................................................................
commonlib: Add timestamp values for forced delays
Add a timestamp entry to allow forced delays to to be seen and accounted for in the timestamp data.
BUG=None TEST=Build only
Signed-off-by: Martin Roth martinroth@chromium.org Change-Id: I26c9fa5c8599a349de2631ac24b9ea8858d8d6c8 --- M src/commonlib/include/commonlib/timestamp_serialized.h 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/47312/3
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47312 )
Change subject: commonlib: Add timestamp values for forced delays ......................................................................
Patch Set 5: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/47312/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47312/2//COMMIT_MSG@7 PS2, Line 7: commonlib: Add timestamp values for forced delays.
Nit: Please remove the dot/period at the end of the git commit message summary.
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47312 )
Change subject: commonlib: Add timestamp values for forced delays ......................................................................
commonlib: Add timestamp values for forced delays
Add a timestamp entry to allow forced delays to to be seen and accounted for in the timestamp data.
BUG=None TEST=Build only
Signed-off-by: Martin Roth martinroth@chromium.org Change-Id: I26c9fa5c8599a349de2631ac24b9ea8858d8d6c8 Reviewed-on: https://review.coreboot.org/c/coreboot/+/47312 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/commonlib/include/commonlib/timestamp_serialized.h 1 file changed, 4 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Arthur Heymans: Looks good to me, approved
diff --git a/src/commonlib/include/commonlib/timestamp_serialized.h b/src/commonlib/include/commonlib/timestamp_serialized.h index dd352ad..a572150 100644 --- a/src/commonlib/include/commonlib/timestamp_serialized.h +++ b/src/commonlib/include/commonlib/timestamp_serialized.h @@ -52,6 +52,8 @@ TS_SELFBOOT_JUMP = 99, TS_START_POSTCAR = 100, TS_END_POSTCAR = 101, + TS_DELAY_START = 110, + TS_DELAY_END = 111,
/* 500+ reserved for vendorcode extensions (500-600: google/chromeos) */ TS_START_COPYVER = 501, @@ -177,6 +179,8 @@ { TS_LOAD_PAYLOAD, "load payload" }, { TS_ACPI_WAKE_JUMP, "ACPI wake jump" }, { TS_SELFBOOT_JUMP, "selfboot jump" }, + { TS_DELAY_START, "Forced delay start" }, + { TS_DELAY_END, "Forced delay end" },
{ TS_START_COPYVER, "starting to load verstage" }, { TS_END_COPYVER, "finished loading verstage" },
-
Arthur Heymans (Code Review) -
Martin Roth (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)