Change in coreboot[master]: mb/google/volteer: Goodix touch panel power-on sequence tuning
Nick Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47502 )
Change subject: mb/google/volteer: Goodix touch panel power-on sequence tuning ......................................................................
mb/google/volteer: Goodix touch panel power-on sequence tuning
1. GPP_E3 PAD_CFG_GPO(GPP_E3, 0, DEEP) 2. generic.reset_delay_ms change to 30
Signed-off-by: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Change-Id: I90ca39312252c668da6298183e598392bc9f9f28 --- M src/mainboard/google/volteer/variants/eldrid/gpio.c M src/mainboard/google/volteer/variants/eldrid/overridetree.cb 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/47502/1
diff --git a/src/mainboard/google/volteer/variants/eldrid/gpio.c b/src/mainboard/google/volteer/variants/eldrid/gpio.c index 3d627e3..24f80a0 100644 --- a/src/mainboard/google/volteer/variants/eldrid/gpio.c +++ b/src/mainboard/google/volteer/variants/eldrid/gpio.c @@ -80,7 +80,7 @@ /* E2 : SPI1_IO3 ==> WLAN_PCIE_WAKE_ODL */ PAD_CFG_GPI(GPP_E2, NONE, DEEP), /* E3 : CPU_GP0 ==> USI_REPORT_EN */ - PAD_CFG_GPO(GPP_E3, 1, DEEP), + PAD_CFG_GPO(GPP_E3, 0, DEEP), /* E4 : SATA_DEVSLP0 ==> M2_SSD_PE_WAKE_ODL */ PAD_CFG_GPI(GPP_E4, NONE, DEEP), /* E6 : THC0_SPI1_RST# ==> GPP_E6_STRAP */ diff --git a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb index 91fbbea..4ec9f37 100644 --- a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb +++ b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb @@ -123,7 +123,7 @@ register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C10)" - register "generic.reset_delay_ms" = "120" + register "generic.reset_delay_ms" = "30" register "generic.reset_off_delay_ms" = "3" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A8)" register "generic.enable_delay_ms" = "12"
Nick Chen has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/47502 )
Change subject: mb/google/volteer: Goodix touch panel power-on sequence tuning ......................................................................
mb/google/volteer: Goodix touch panel power-on sequence tuning
1. GPP_E3 PAD_CFG_GPO(GPP_E3, 0, DEEP) 2. generic.reset_delay_ms change to 30
BUG=b:171365316 Signed-off-by: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Change-Id: I90ca39312252c668da6298183e598392bc9f9f28 --- M src/mainboard/google/volteer/variants/eldrid/gpio.c M src/mainboard/google/volteer/variants/eldrid/overridetree.cb 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/47502/2
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47502 )
Change subject: mb/google/volteer: Goodix touch panel power-on sequence tuning ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/47502/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47502/2//COMMIT_MSG@7 PS2, Line 7: volteer volteer/var/eldrid
Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47502
to look at the new patch set (#3).
Change subject: mb/google/volteer/variants/eldrid:: Goodix touch panel power-on sequence tuning ......................................................................
mb/google/volteer/variants/eldrid:: Goodix touch panel power-on sequence tuning
1. GPP_E3 PAD_CFG_GPO(GPP_E3, 0, DEEP) 2. generic.reset_delay_ms change to 30
BUG=b:171365316 Signed-off-by: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Change-Id: I90ca39312252c668da6298183e598392bc9f9f28 --- M src/mainboard/google/volteer/variants/eldrid/gpio.c M src/mainboard/google/volteer/variants/eldrid/overridetree.cb 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/47502/3
Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47502
to look at the new patch set (#4).
Change subject: mb/google/volteer/variants/eldrid: Goodix touch panel power-on sequence tuning ......................................................................
mb/google/volteer/variants/eldrid: Goodix touch panel power-on sequence tuning
1. GPP_E3 PAD_CFG_GPO(GPP_E3, 0, DEEP) 2. generic.reset_delay_ms change to 30
BUG=b:171365316 Signed-off-by: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Change-Id: I90ca39312252c668da6298183e598392bc9f9f28 --- M src/mainboard/google/volteer/variants/eldrid/gpio.c M src/mainboard/google/volteer/variants/eldrid/overridetree.cb 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/47502/4
Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47502
to look at the new patch set (#5).
Change subject: mb/google/volteer/variants/eldrid: Goodix touch panel power-on sequence tuning ......................................................................
mb/google/volteer/variants/eldrid: Goodix touch panel power-on sequence tuning
1. GPP_E3 PAD_CFG_GPO(GPP_E3, 0, DEEP) 2. generic.reset_delay_ms change to 30
BUG=b:171365316 Signed-off-by: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Change-Id: I90ca39312252c668da6298183e598392bc9f9f28 --- M src/mainboard/google/volteer/variants/eldrid/gpio.c M src/mainboard/google/volteer/variants/eldrid/overridetree.cb 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/47502/5
Nick Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47502 )
Change subject: mb/google/volteer/variants/eldrid: Goodix touch panel power-on sequence tuning ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47502/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47502/2//COMMIT_MSG@7 PS2, Line 7: volteer
volteer/var/eldrid
Done
Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47502
to look at the new patch set (#6).
Change subject: volteer/variants/eldrid: Goodix touch panel power-on sequence tuning ......................................................................
volteer/variants/eldrid: Goodix touch panel power-on sequence tuning
1. GPP_E3 PAD_CFG_GPO(GPP_E3, 0, DEEP) 2. generic.reset_delay_ms change to 30
BUG=b:171365316 Signed-off-by: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Change-Id: I90ca39312252c668da6298183e598392bc9f9f28 --- M src/mainboard/google/volteer/variants/eldrid/gpio.c M src/mainboard/google/volteer/variants/eldrid/overridetree.cb 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/47502/6
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47502 )
Change subject: volteer/variants/eldrid: Goodix touch panel power-on sequence tuning ......................................................................
Patch Set 6: Code-Review+2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47502 )
Change subject: volteer/variants/eldrid: Goodix touch panel power-on sequence tuning ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47502/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47502/6//COMMIT_MSG@9 PS6, Line 9: GPP_E3 PAD_CFG_GPO(GPP_E3, 0, DEEP) suggest: Enable panel stop GPIO in ramstage
Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47502
to look at the new patch set (#7).
Change subject: volteer/variants/eldrid: Goodix touch panel power-on sequence tuning ......................................................................
volteer/variants/eldrid: Goodix touch panel power-on sequence tuning
1. Enable panel stop GPIO in ramstage 2. generic.reset_delay_ms change to 30
BUG=b:171365316 Signed-off-by: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Change-Id: I90ca39312252c668da6298183e598392bc9f9f28 --- M src/mainboard/google/volteer/variants/eldrid/gpio.c M src/mainboard/google/volteer/variants/eldrid/overridetree.cb 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/47502/7
Nick Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47502 )
Change subject: volteer/variants/eldrid: Goodix touch panel power-on sequence tuning ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47502/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47502/6//COMMIT_MSG@9 PS6, Line 9: GPP_E3 PAD_CFG_GPO(GPP_E3, 0, DEEP)
suggest: Enable panel stop GPIO in ramstage
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47502 )
Change subject: volteer/variants/eldrid: Goodix touch panel power-on sequence tuning ......................................................................
volteer/variants/eldrid: Goodix touch panel power-on sequence tuning
1. Enable panel stop GPIO in ramstage 2. generic.reset_delay_ms change to 30
BUG=b:171365316 Signed-off-by: Nick Chen nick_xr_chen@wistron.corp-partner.google.com Change-Id: I90ca39312252c668da6298183e598392bc9f9f28 Reviewed-on: https://review.coreboot.org/c/coreboot/+/47502 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Caveh Jalali caveh@chromium.org --- M src/mainboard/google/volteer/variants/eldrid/gpio.c M src/mainboard/google/volteer/variants/eldrid/overridetree.cb 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Caveh Jalali: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/eldrid/gpio.c b/src/mainboard/google/volteer/variants/eldrid/gpio.c index 3d627e3..24f80a0 100644 --- a/src/mainboard/google/volteer/variants/eldrid/gpio.c +++ b/src/mainboard/google/volteer/variants/eldrid/gpio.c @@ -80,7 +80,7 @@ /* E2 : SPI1_IO3 ==> WLAN_PCIE_WAKE_ODL */ PAD_CFG_GPI(GPP_E2, NONE, DEEP), /* E3 : CPU_GP0 ==> USI_REPORT_EN */ - PAD_CFG_GPO(GPP_E3, 1, DEEP), + PAD_CFG_GPO(GPP_E3, 0, DEEP), /* E4 : SATA_DEVSLP0 ==> M2_SSD_PE_WAKE_ODL */ PAD_CFG_GPI(GPP_E4, NONE, DEEP), /* E6 : THC0_SPI1_RST# ==> GPP_E6_STRAP */ diff --git a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb index f9ab7c9..72571c0 100644 --- a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb +++ b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb @@ -123,7 +123,7 @@ register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C10)" - register "generic.reset_delay_ms" = "120" + register "generic.reset_delay_ms" = "30" register "generic.reset_off_delay_ms" = "3" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A8)" register "generic.enable_delay_ms" = "12"
-
Caveh Jalali (Code Review) -
Nick Chen (Code Review)
-
Patrick Georgi (Code Review)
-
Tim Wawrzynczak (Code Review)