Attention is currently required from: Eric Lai, Kun Liu, Paul Menzel, Wentao Qin.
Jian Tong has posted comments on this change by Jian Tong. ( https://review.coreboot.org/c/coreboot/+/82573?usp=email )
Change subject: mb/google/brox/var/lotso: Update gpio setting ......................................................................
Patch Set 5:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82573/comment/df254d9b_34cb6d4e?usp... : PS2, Line 2: tongjian
Jian Tong […]
Done
https://review.coreboot.org/c/coreboot/+/82573/comment/0c7a8436_0c3973e1?usp... : PS2, Line 9: latest schematics
Please add some revision.
Done
File src/mainboard/google/brox/variants/lotso/gpio.c:
https://review.coreboot.org/c/coreboot/+/82573/comment/67fd1951_11bf13e0?usp... : PS2, Line 3: /* This header block is used to supply information to arbitrage, a : * google-internal tool. Updating it incorrectly will lead to issues, : * so please don't update it unless a change is specifically required. : * BaseID: E3110FFB1FCDA587 : * Overrides: None : */
Please use the recommended multi-line comment style.
Done
https://review.coreboot.org/c/coreboot/+/82573/comment/fcbbdeb2_64a67d40?usp... : PS2, Line 58:
Remove?
Done