Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40023 )
Change subject: mb/volteer: enable Early Command Training
......................................................................
Patch Set 9: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/40023/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40023/5//COMMIT_MSG@11
PS5, Line 11: ECT enabled.
Thanks, but please add that clarification to the commit message.
Done
https://review.coreboot.org/c/coreboot/+/40023/7/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/baseboard/memory.c:
https://review.coreboot.org/c/coreboot/+/40023/7/src/mainboard/google/voltee...
PS7, Line 61: *E
nit - add a space betwee '*' and 'E'
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40023
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I674c30f4dfc1af6c0c4a460d66684545a190caf3
Gerrit-Change-Number: 40023
Gerrit-PatchSet: 9
Gerrit-Owner: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 09 Apr 2020 06:59:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Comment-In-Reply-To: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-MessageType: comment