Attention is currently required from: Felix Held.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59055 )
Change subject: drivers/ipmi: Use correct unsigned int length modifier
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
the custom_count struct element in fru_board_info and fru_chassis_info should be an unsigned integer
Currently, they are not. For example:
struct fru_chassis_info {
uint8_t chassis_type;
char *chassis_partnumber;
char *serial_number;
char **chassis_custom;
int custom_count;
};
Do you want me to change that?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59055
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0c4266b19d56fa88abc397f305154d473ae1a93
Gerrit-Change-Number: 59055
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 03 Jan 2022 09:37:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment