Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37155 )
Change subject: mb/Kconfig: Add a warning on boards with a ROMCC_BOOTLOCK ......................................................................
mb/Kconfig: Add a warning on boards with a ROMCC_BOOTLOCK
This feature and therefore the boards using it, will be deprecated soon.
Change-Id: I1e970dd0613702346b5764d2b56012a72ed62cde Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/37155/1
diff --git a/src/mainboard/Kconfig b/src/mainboard/Kconfig index c88d317..97086b7 100644 --- a/src/mainboard/Kconfig +++ b/src/mainboard/Kconfig @@ -1,5 +1,9 @@ comment "Important: Run 'make distclean' before switching boards"
+if ROMCC_BOOTBLOCK +comment "Systems with ROMCC bootblocks will be deprecated soon!" +endif + choice prompt "Mainboard vendor" default VENDOR_EMULATION
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37155 )
Change subject: mb/Kconfig: Add a warning on boards with a ROMCC_BOOTLOCK ......................................................................
Patch Set 2: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37155 )
Change subject: mb/Kconfig: Add a warning on boards with a ROMCC_BOOTLOCK ......................................................................
Patch Set 3: Code-Review+1
Hello Kyösti Mälkki, Angel Pons, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37155
to look at the new patch set (#4).
Change subject: mb/Kconfig: Add a warning on boards with a ROMCC_BOOTLOCK ......................................................................
mb/Kconfig: Add a warning on boards with a ROMCC_BOOTLOCK
This feature and therefore the boards using it, will be deprecated soon.
Change-Id: I1e970dd0613702346b5764d2b56012a72ed62cde Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/37155/4
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37155 )
Change subject: mb/Kconfig: Add a warning on boards with a ROMCC_BOOTLOCK ......................................................................
Patch Set 6: Code-Review+1
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37155 )
Change subject: mb/Kconfig: Add a warning on boards with a ROMCC_BOOTLOCK ......................................................................
Patch Set 6: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37155 )
Change subject: mb/Kconfig: Add a warning on boards with a ROMCC_BOOTLOCK ......................................................................
mb/Kconfig: Add a warning on boards with a ROMCC_BOOTLOCK
This feature and therefore the boards using it, will be deprecated soon.
Change-Id: I1e970dd0613702346b5764d2b56012a72ed62cde Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/37155 Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Kyösti Mälkki: Looks good to me, but someone else must approve HAOUAS Elyes: Looks good to me, but someone else must approve Angel Pons: Looks good to me, but someone else must approve
diff --git a/src/mainboard/Kconfig b/src/mainboard/Kconfig index c88d317..97086b7 100644 --- a/src/mainboard/Kconfig +++ b/src/mainboard/Kconfig @@ -1,5 +1,9 @@ comment "Important: Run 'make distclean' before switching boards"
+if ROMCC_BOOTBLOCK +comment "Systems with ROMCC bootblocks will be deprecated soon!" +endif + choice prompt "Mainboard vendor" default VENDOR_EMULATION
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
HAOUAS Elyes (Code Review)
-
Kyösti Mälkki (Code Review)
-
Patrick Georgi (Code Review)