Hello Chris Wang,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/34903
to review the following change.
Change subject: mb/google/kahlee/treeya: remove keyboard backlight support ......................................................................
mb/google/kahlee/treeya: remove keyboard backlight support
Treeya doesn't support the keyboard backlight.
BUG=b:135551210 BRANCH=grunt TEST=emerge-grunt coreboot
Signed-off-by: Chris Wang chris.wang@amd.corp-partner.google.com Change-Id: I02dfc77d3cb7ac00b3f10d577d92775db99c1bdf --- M src/mainboard/google/kahlee/variants/treeya/include/variant/ec.h 1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/34903/1
diff --git a/src/mainboard/google/kahlee/variants/treeya/include/variant/ec.h b/src/mainboard/google/kahlee/variants/treeya/include/variant/ec.h index 4a1c7fc..2d48018 100644 --- a/src/mainboard/google/kahlee/variants/treeya/include/variant/ec.h +++ b/src/mainboard/google/kahlee/variants/treeya/include/variant/ec.h @@ -15,9 +15,6 @@
#include <baseboard/ec.h>
-/* Enable EC backed Keyboard Backlight in ACPI */ -#define EC_ENABLE_KEYBOARD_BACKLIGHT - /* Enable Tablet switch */ #define EC_ENABLE_TBMC_DEVICE
Edward Hill has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34903 )
Change subject: mb/google/kahlee/treeya: remove keyboard backlight support ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34903 )
Change subject: mb/google/kahlee/treeya: remove keyboard backlight support ......................................................................
mb/google/kahlee/treeya: remove keyboard backlight support
Treeya doesn't support the keyboard backlight.
BUG=b:135551210 BRANCH=grunt TEST=emerge-grunt coreboot
Signed-off-by: Chris Wang chris.wang@amd.corp-partner.google.com Change-Id: I02dfc77d3cb7ac00b3f10d577d92775db99c1bdf Reviewed-on: https://review.coreboot.org/c/coreboot/+/34903 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Edward Hill ecgh@chromium.org --- M src/mainboard/google/kahlee/variants/treeya/include/variant/ec.h 1 file changed, 0 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Edward Hill: Looks good to me, approved
diff --git a/src/mainboard/google/kahlee/variants/treeya/include/variant/ec.h b/src/mainboard/google/kahlee/variants/treeya/include/variant/ec.h index 4a1c7fc..2d48018 100644 --- a/src/mainboard/google/kahlee/variants/treeya/include/variant/ec.h +++ b/src/mainboard/google/kahlee/variants/treeya/include/variant/ec.h @@ -15,9 +15,6 @@
#include <baseboard/ec.h>
-/* Enable EC backed Keyboard Backlight in ACPI */ -#define EC_ENABLE_KEYBOARD_BACKLIGHT - /* Enable Tablet switch */ #define EC_ENABLE_TBMC_DEVICE
-
chris wang (Code Review) -
Edward Hill (Code Review)
-
Martin Roth (Code Review)