[M] Change in coreboot[main]: mb/google/corsola/var/chinchou: Configure I2C and I2S interface for A...

[Yang Wu (Code Review)]

Attention is currently required from: Hung-Te Lin, Jiaxin Yu, Yidi Lin, Yu-Ping Wu.

Yang Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79064?usp=email )

Change subject: mb/google/corsola/var/chinchou: Configure I2C and I2S interface for ALC5650
......................................................................

Patch Set 4:

(9 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/79064/comment/6efa73ed_29fca1e2 :
PS3, Line 7: mb/google/corsola: Add audio codec ALC5650 for Chinchou Devbeep
> mb/google/corsola/var/chinchou: Configure I2C and I2S interface for ALC5650

Done

https://review.coreboot.org/c/coreboot/+/79064/comment/1e45ead2_bce6935f :
PS3, Line 9: Chinchou uses I2S1 and I2C5 to do the Devbeep in Depthcharge.
> Configure I2S1 and I2C5 for ALC5650 to support beep sound in depthcharge.

Done

https://review.coreboot.org/c/coreboot/+/79064/comment/8f286cdf_249ccb03 :
PS3, Line 10:
> BRANCH=corsola

Done

https://review.coreboot.org/c/coreboot/+/79064/comment/07c588d1_069211e8 :
PS3, Line 12: Verify Devbeep at Depthcharge console
> Verify `devbeep` in depthcharge console

Done

File src/mainboard/google/corsola/mainboard.c:

https://review.coreboot.org/c/coreboot/+/79064/comment/d912eea7_cdc17850 :
PS3, Line 29: configure_audio_ALC5645
> what about configure_alc5645() ?

Done

https://review.coreboot.org/c/coreboot/+/79064/comment/f5e26a58_145b93ae :
PS3, Line 39: Timing
> timing

Done

https://review.coreboot.org/c/coreboot/+/79064/comment/a3f1edb6_aa5ed21e :
PS3, Line 39: i2c
> I2C

Done

https://review.coreboot.org/c/coreboot/+/79064/comment/6d24d6c9_0c10e793 :
PS3, Line 42: set
> Set

Done

File src/soc/mediatek/mt8186/include/soc/pll.h:

https://review.coreboot.org/c/coreboot/+/79064/comment/a589e150_246860ab :
PS3, Line 11: #include <assert.h>
> move it to pll. […]

Done