Attention is currently required from: Aseda Aboagye.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55558 )
Change subject: mb/google/dedede: Configure CBI EEPROM WP
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/dedede/smihandler.c:
https://review.coreboot.org/c/coreboot/+/55558/comment/eca3b10f_9cbc1cc5
PS9, Line 76: if (spi_flash_status(spi_flash_dev, &sr1) < 0) {
Coverity complains that `spi_flash_dev` might be NULL. How about updating the check?
if (!spi_flash_dev || spi_flash_status(spi_flash_dev, &sr1) < 0) {
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55558
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic103037921ec7d2f96f86178675c11a3a1357d1b
Gerrit-Change-Number: 55558
Gerrit-PatchSet: 9
Gerrit-Owner: Aseda Aboagye
aaboagye@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Aseda Aboagye
aaboagye@google.com
Gerrit-Comment-Date: Wed, 02 Nov 2022 00:48:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment