Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/28383 )
Change subject: riscv: separately define stack locations at different stages
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Looks good to me, I'm not 100% familiar with memlayout files
https://review.coreboot.org/#/c/28383/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/28383/1//COMMIT_MSG@9
PS1, Line 9: BOOTBLOCK/ROMSTAGE run in CAR/scratchpad. When RAMSTAGE begin
"When RAMSTAGE begins ..."
--
To view, visit
https://review.coreboot.org/28383
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37a0c1928052cabf61ba5c25b440363b75726782
Gerrit-Change-Number: 28383
Gerrit-PatchSet: 1
Gerrit-Owner: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shawn Chang
citypw@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 30 Aug 2018 11:58:08 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes