Attention is currently required from: Arthur Heymans, Jérémy Compostella, Subrata Banik.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81886?usp=email )
Change subject: arch/x86: Prevent .text/.init overlap with older linkers ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81886/comment/52c0121f_702c8e8a : PS2, Line 11: (binutils 2.3x) Are you sure this is used with the main branch? I was told ChromeOS always uses the newest toolchain (and hence we have to restrict toolchain updates to the releases). binutils was updated to 2.40 a year ago.
https://review.coreboot.org/c/coreboot/+/81886/comment/145b0674_bdf4f286 : PS2, Line 11: Default is 1024 bytes (1 KiB) There was a comment on another change (CB:81678) stating that SIZEOF() is returning 0 (with the old binutils). If that's the case, 1KiB might not be enough (possibly depending on alignment).