Youness Alaoui has posted comments on this change. ( https://review.coreboot.org/19849 )
Change subject: console/flashsconsole: Add spi flash console for debugging
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/#/c/19849/8/src/drivers/spi/flashconsole.c
File src/drivers/spi/flashconsole.c:
Line 79: if (rdev_readat(rdev, buffer, offset, len))
rdev_readat() and rdev_writeat() return the length on success, < 0 on error
:facepalm: I guess it's time to call it a day.
Fixed.
--
To view, visit
https://review.coreboot.org/19849
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74a297b94f6881d8c27cbe5168f161d8331c3df3
Gerrit-PatchSet: 8
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Youness Alaoui
snifikino@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Youness Alaoui
snifikino@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-HasComments: Yes