Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58899 )
Change subject: [RFC] ChromeOS: Add DECLARE_x_CROS_GPIOS() ......................................................................
Patch Set 1:
(8 comments)
File src/vendorcode/google/chromeos/chromeos.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132161): https://review.coreboot.org/c/coreboot/+/58899/comment/e23bd7c0_3223472e PS1, Line 110: #define DECLARE_CROS_GPIOS(x) \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132161): https://review.coreboot.org/c/coreboot/+/58899/comment/cb4a1d82_741183e2 PS1, Line 110: #define DECLARE_CROS_GPIOS(x) \ Macros with flow control statements should be avoided
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132161): https://review.coreboot.org/c/coreboot/+/58899/comment/1c7600d2_9552099e PS1, Line 111: const struct cros_gpio *variant_cros_gpios(size_t *num) \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132161): https://review.coreboot.org/c/coreboot/+/58899/comment/fc7bed27_aad62bd8 PS1, Line 112: { \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132161): https://review.coreboot.org/c/coreboot/+/58899/comment/13db4677_5d85e9e4 PS1, Line 117: #define DECLARE_WEAK_CROS_GPIOS(x) \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132161): https://review.coreboot.org/c/coreboot/+/58899/comment/63afdc10_e7fc2225 PS1, Line 117: #define DECLARE_WEAK_CROS_GPIOS(x) \ Macros with flow control statements should be avoided
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132161): https://review.coreboot.org/c/coreboot/+/58899/comment/1681f78a_c20b259d PS1, Line 118: const struct cros_gpio *__weak variant_cros_gpios(size_t *num) \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132161): https://review.coreboot.org/c/coreboot/+/58899/comment/11202e67_059bd5b1 PS1, Line 119: { \ please, no space before tabs
-
build bot (Jenkins) (Code Review)