Attention is currently required from: Matt DeVillier, Subrata Banik.
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84133?usp=email )
Change subject: drivers/usb/acpi: Add DSM for Intel Bluetooth ......................................................................
Patch Set 5:
(4 comments)
File src/drivers/usb/acpi/chip.h:
https://review.coreboot.org/c/coreboot/+/84133/comment/681e8e0b_8d96c7ba?usp... : PS3, Line 51: bool intel_bt;
can you please use a meaningful name ? I don't understand what you mean by `intel_bt` ? is it like ` […]
Done
File src/drivers/usb/acpi/usb_acpi.c:
https://review.coreboot.org/c/coreboot/+/84133/comment/f1a529bc_c968dc0d?usp... : PS3, Line 12:
just one space to start the comment
Done
https://review.coreboot.org/c/coreboot/+/84133/comment/fd872506_050f5116?usp... : PS3, Line 27: 0x03
can you please explain the meaning of hard coded value ?
BIT(0) and BIT(1) - supported and other functions are supported.
https://review.coreboot.org/c/coreboot/+/84133/comment/e2c365d7_3e389a6e?usp... : PS3, Line 36: /* aa10f4e0-81ac-4233-abf6-3b2ac50e28d9 */
unable to follow why you have used the GUID here ?
THought it made it easier to follow - removed.
-
Sean Rhodes (Code Review)