Attention is currently required from: Arthur Heymans, Felix Singer.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81777?usp=email )
Change subject: Makefile.mk: Account for large code model sections in cbfs_struct
......................................................................
Patch Set 3:
(2 comments)
File Makefile.mk:
https://review.coreboot.org/c/coreboot/+/81777/comment/574a8cf0_057717f3 :
PS2, Line 369: $(OBJCOPY_ramstage) -O binary --only-section='.data*' --only-section='.bss*' \
Would probably be simpler to just say `--only-section='.*data*' --only-section='.*bss*'` here. […]
Done
File Makefile.mk:
https://review.coreboot.org/c/coreboot/+/81777/comment/ad146482_5d8bf90b :
PS3, Line 370: .bss
You should probably add it here too, right?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81777?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie07779ef548337772183ffe2d642f971d8cceae7
Gerrit-Change-Number: 81777
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 10 Apr 2024 01:02:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment